You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mobile): a settings row an older environment left mixed can be set off - #39755
Claude Opus 5.5 (Claude Code), opening this fix for Peyton (@not-compromised).
Problem
In mobile server settings with several environments selected, a server older than a setting drops it on save and the row stays mixed. Its "Mixed · Set on" button (ListToggleRow) always sends on, so the setting can't be turned off there.
To reproduce: in the mobile app, open server settings with All environments selected, including a server older than a setting. Tap "Mixed · Set on" twice. Expected: the second tap sets it off. On main both taps send on.
Change
A mixed row now flips the value last picked on it, and the button reads "Mixed · Set off" after a pick of on. Before any pick it still sets the value on. If another device makes a row mixed after you set it on, the next tap sets it off.
The "Set off" label and its accessibility label are two new strings, written as full sentences rather than built from fragments. I translated them into all 10 mobile catalogs to match the existing "Set on" strings; a native speaker may want to adjust them.
Scope
A small fix for an obvious bug, the stuck row #18334 describes, so there's no separate issue. This is the mobile half of #39754, which fixes the same row on web. The two don't depend on each other.
Verification
New ListToggleRow test: two taps on a row that stays mixed send true, true on main and true, false here, and the button reads "Mixed · Set off" between them.
vp run check:changed and vp run i18n:check pass.
Not run on a device: no iOS or Android simulator was available, so there are no screenshots. The only visible change is the button text.
…t off
With several environments selected, a server that predates a setting drops
it on save, so the row stays mixed. Its "Mixed · Set on" button always sent
on, so every tap repeated the write that server dropped.
A mixed row now flips the value last picked on it, and its button says
"Set off" after a pick of on. Before any pick it still sets the value on.
Reviewing files that changed from the base of the PR and between 3235276 and 5a4de52.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
ListToggleRow now alternates mixed-value selections based on the last picked value, starting with on. Button text and accessibility labels reflect the next selection. Translations and a test cover the updated behavior.
Changes: Mixed-value list toggle
Layer / File(s)
Summary
Track selections and update labels apps/mobile/src/components/ui/ListToggleRow.tsx, apps/mobile/src/i18n/translations/*.json
The component records each selected value. For mixed values, it alternates the next selection and updates the button text and accessibility label. Translations add labels for turning settings off.
Test mixed-state selection apps/mobile/src/components/ui/ListToggleRow.test.tsx, apps/mobile/vite.config.ts
A test checks that two clicks on a mixed-value row select true and then false. Vite includes the test in the React test project.
A mixed-value row now offers "Set off" after an on pick, so a row that stays mixed can be turned off on the next tap. The change is small and covered by a test. Merge risk is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the change: a settings row left mixed by an older environment can now be set off. It matches the main behavior change in ListToggleRow (mixed rows flip the last picked value) and the f…
Description check
The description follows the template sections: Problem, Change, Scope, and Verification. It explains the bug, the fix, why no issue is linked (small obvious bug, with a reference to #18334), and the t…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change: a settings row left mixed by an older environment can now be set off. It matches the main behavior change in ListToggleRow (mixed rows flip the last picked value) and the fix described in the objectives. It uses the conventional commit format the template recommends.
Full details: Description check
Explanation
The description follows the template sections: Problem, Change, Scope, and Verification. It explains the bug, the fix, why no issue is linked (small obvious bug, with a reference to #18334), and the tests and checks run. It also states that device testing was not done and no screenshots exist, which is a gap for a UI-visible text change. The template asks for before/after screenshots for UI changes, so the author should either add them or explain more fully why they are missing. The author also should confirm that the referenced stuck row issue (#18334) is the bug, since the Scope section relies on it. The 'Verification' section lists focused tests, which meets the template's requirement.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Paired the native iOS app with a current environment and an older environment that drops ghqCloneLayout. Selected All connected environments, opened Source control & issues, turned Clone into host folders on, then tapped the resulting mixed button. Same iPhone 18 Pro, iOS 27.2, light theme and viewport on both commits.
Base remained mixed after two further taps, with the current environment true and the older environment false. Head offered Set off and returned both environments to false.
Proven in the real iOS app on iPhone 18 Pro, iOS 27.2, light theme. Both runs used fresh state and a real older server that drops the setting.
Steps: connect both environments, open Source control & issues for all connected environments, turn Clone into host folders on, then tap the mixed button.
Scenario driver. The runner reported failsOnBase=true and passesOnHead=true. Server settings confirmed true remained on base, while head returned to default false.
Not shown:
Android and translated labels were not exercised; this proof covers the reported interaction on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In mobile server settings with several environments selected, a server older than a setting drops it on save and the row stays mixed. Its "Mixed · Set on" button (
ListToggleRow) always sends on, so the setting can't be turned off there.To reproduce: in the mobile app, open server settings with All environments selected, including a server older than a setting. Tap "Mixed · Set on" twice. Expected: the second tap sets it off. On main both taps send on.
Change
A mixed row now flips the value last picked on it, and the button reads "Mixed · Set off" after a pick of on. Before any pick it still sets the value on. If another device makes a row mixed after you set it on, the next tap sets it off.
The "Set off" label and its accessibility label are two new strings, written as full sentences rather than built from fragments. I translated them into all 10 mobile catalogs to match the existing "Set on" strings; a native speaker may want to adjust them.
Scope
A small fix for an obvious bug, the stuck row #18334 describes, so there's no separate issue. This is the mobile half of #39754, which fixes the same row on web. The two don't depend on each other.
Verification
ListToggleRowtest: two taps on a row that stays mixed sendtrue, trueon main andtrue, falsehere, and the button reads "Mixed · Set off" between them.vp run check:changedandvp run i18n:checkpass.Opus 5.5 via T3 Code, Claude Code harness