Skip to content

fix(mobile): a settings row an older environment left mixed can be set off - #39755

Merged
juliusmarminge merged 3 commits into
pingdotgg:mainfrom
not-compromised:fix/mobile-mixed-switch
Nov 20, 2026
Merged

juliusmarminge merged 3 commits into
pingdotgg:mainfrom
not-compromised:fix/mobile-mixed-switch

Conversation

@not-compromised

Copy link
Copy Markdown
Contributor

Claude Opus 5.5 (Claude Code), opening this fix for Peyton (@not-compromised).

Problem

In mobile server settings with several environments selected, a server older than a setting drops it on save and the row stays mixed. Its "Mixed · Set on" button (ListToggleRow) always sends on, so the setting can't be turned off there.

To reproduce: in the mobile app, open server settings with All environments selected, including a server older than a setting. Tap "Mixed · Set on" twice. Expected: the second tap sets it off. On main both taps send on.

Change

A mixed row now flips the value last picked on it, and the button reads "Mixed · Set off" after a pick of on. Before any pick it still sets the value on. If another device makes a row mixed after you set it on, the next tap sets it off.

The "Set off" label and its accessibility label are two new strings, written as full sentences rather than built from fragments. I translated them into all 10 mobile catalogs to match the existing "Set on" strings; a native speaker may want to adjust them.

Scope

A small fix for an obvious bug, the stuck row #18334 describes, so there's no separate issue. This is the mobile half of #39754, which fixes the same row on web. The two don't depend on each other.

Verification

  • New ListToggleRow test: two taps on a row that stays mixed send true, true on main and true, false here, and the button reads "Mixed · Set off" between them.
  • vp run check:changed and vp run i18n:check pass.
  • Not run on a device: no iOS or Android simulator was available, so there are no screenshots. The only visible change is the button text.

Opus 5.5 via T3 Code, Claude Code harness

…t off

With several environments selected, a server that predates a setting drops
it on save, so the row stays mixed. Its "Mixed · Set on" button always sent
on, so every tap repeated the write that server dropped.

A mixed row now flips the value last picked on it, and its button says
"Set off" after a pick of on. Before any pick it still sets the value on.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3235276 and 5a4de52.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

ListToggleRow now alternates mixed-value selections based on the last picked value, starting with on. Button text and accessibility labels reflect the next selection. Translations and a test cover the updated behavior.

Changes: Mixed-value list toggle

Layer / File(s) Summary
Track selections and update labels
apps/mobile/src/components/ui/ListToggleRow.tsx, apps/mobile/src/i18n/translations/*.json
The component records each selected value. For mixed values, it alternates the next selection and updates the button text and accessibility label. Translations add labels for turning settings off.
Test mixed-state selection
apps/mobile/src/components/ui/ListToggleRow.test.tsx, apps/mobile/vite.config.ts
A test checks that two clicks on a mixed-value row select true and then false. Vite includes the test in the React test project.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: bugfix

Suggested reviewers: maria-rcks, juliusmarminge, bil0000

Merge Risk: Minimal · previous review 433ae

A mixed-value row now offers "Set off" after an on pick, so a row that stays mixed can be turned off on the next tap. The change is small and covered by a test. Merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: a settings row left mixed by an older environment can now be set off. It matches the main behavior change in ListToggleRow (mixed rows flip the last picked value) and the f…
Description check Passed The description follows the template sections: Problem, Change, Scope, and Verification. It explains the bug, the fix, why no issue is linked (small obvious bug, with a reference to #18334), and the t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a settings row left mixed by an older environment can now be set off. It matches the main behavior change in ListToggleRow (mixed rows flip the last picked value) and the fix described in the objectives. It uses the conventional commit format the template recommends.

Full details: Description check

Explanation

The description follows the template sections: Problem, Change, Scope, and Verification. It explains the bug, the fix, why no issue is linked (small obvious bug, with a reference to #18334), and the tests and checks run. It also states that device testing was not done and no screenshots exist, which is a gap for a UI-visible text change. The template asks for before/after screenshots for UI changes, so the author should either add them or explain more fully why they are missing. The author also should confirm that the referenced stuck row issue (#18334) is the bug, since the Scope section relies on it. The 'Verification' section lists focused tests, which meets the template's requirement.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e74b795 and 433ae9a.

Files selected for processing: 13

  • apps/mobile/src/components/ui/ListToggleRow.test.tsx
  • apps/mobile/src/components/ui/ListToggleRow.tsx
  • apps/mobile/src/i18n/translations/de.json
  • apps/mobile/src/i18n/translations/en.json
  • apps/mobile/src/i18n/translations/es.json
  • apps/mobile/src/i18n/translations/fr.json
  • apps/mobile/src/i18n/translations/ja.json
  • apps/mobile/src/i18n/translations/ko.json
  • apps/mobile/src/i18n/translations/pt-BR.json
  • apps/mobile/src/i18n/translations/ru.json
  • apps/mobile/src/i18n/translations/sv.json
  • apps/mobile/src/i18n/translations/zh.json
  • apps/mobile/vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Paired the native iOS app with a current environment and an older environment that drops ghqCloneLayout. Selected All connected environments, opened Source control & issues, turned Clone into host folders on, then tapped the resulting mixed button. Same iPhone 18 Pro, iOS 27.2, light theme and viewport on both commits.

Before — 97e7834f4b After — 3235276fba
After turning on Before: Mixed Set on After: Mixed Set off
After tapping mixed Before: still Mixed Set on After: unchecked switch
Recording Before, original speed · 4× speed After, original speed · 4× speed

Base remained mixed after two further taps, with the current environment true and the older environment false. Head offered Set off and returned both environments to false.

Reproduction drivers, fixture setup and saved-value observations · Attempted scenario source. The scenario could not complete client installation; the evidence above comes from the manual native app runs.

Not shown:

  • Android, other settings rows and translated labels were not exercised; this proof covers Clone into host folders in English on iOS.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Proven in the real iOS app on iPhone 18 Pro, iOS 27.2, light theme. Both runs used fresh state and a real older server that drops the setting.

Steps: connect both environments, open Source control & issues for all connected environments, turn Clone into host folders on, then tap the mixed button.

State Before · e24f0c7154 After · 5a4de52780
After turning on Before: mixed row offers Set on After: mixed row offers Set off
After tapping mixed button Before: setting remains mixed and on After: setting is unchecked and off
Interaction Before recording After recording

Scenario driver. The runner reported failsOnBase=true and passesOnHead=true. Server settings confirmed true remained on base, while head returned to default false.

Not shown:

  • Android and translated labels were not exercised; this proof covers the reported interaction on iOS.

@juliusmarminge
juliusmarminge merged commit 7085c47 into pingdotgg:main Nov 20, 2026
34 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 20, 2026
HNRow pushed a commit to HNRow/r3code that referenced this pull request Nov 20, 2026
…t off (pingdotgg#39755)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 7085c47)
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 20, 2026
**v0.1.12-nightly.20261120.5009** · 30 changes from 9 contributors

- **Secret cards.** Enter multiple secret values in one card and show or hide masked values on the web.
- **Shared Antigravity skills.** Use Antigravity skills registered in shared or external directories.
- **Thread failure reasons.** See why the latest thread run failed when checking it from the command line.
- **Draft pull requests.** Create draft pull requests directly without briefly announcing them as ready for review or starting unnecessary CI runs.
- **Azure DevOps Bugs.** Read and edit Bug descriptions stored in Repro Steps from Issues.
- **Stable file previews.** Keep HTML previews and attachments open while agents work, without losing form input to unnecessary reloads.
- **T3 Connect port forwarding.** Forward ports to your machine when connected to another machine through T3 Connect.

### Plus 21 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(server): Claude gateway cooldown survives an untyped SDK rejection by @juliusmarminge in pingdotgg/t3code#39695
* fix(release): Windows resource monitor starts without the Visual C++ runtime by @jieyuexing in pingdotgg/t3code#39683
* fix(server): turn authorship works on Git before 2.36 by @juliusmarminge in pingdotgg/t3code#39702
* fix(mobile): new thread says the host has no model instead of asking to connect by @juliusmarminge in pingdotgg/t3code#39713
* fix(antigravity): keep truncated command text valid Unicode by @Lucenx9 in pingdotgg/t3code#39697
* fix(antigravity): honor the saved thinking level in text generation by @Lucenx9 in pingdotgg/t3code#39720
* fix(azure-devops): read and edit a Bug's text in Repro Steps by @juliusmarminge in pingdotgg/t3code#39738
* fix(web): stop reloading unchanged file previews during agent commands by @juliusmarminge in pingdotgg/t3code#39736
* fix(server): a released provider session ends its tool call nodes too by @jieyuexing in pingdotgg/t3code#39734
* fix(server): watch_pull_request says a merge or close wakes the agent by @juliusmarminge in pingdotgg/t3code#39739
* fix(server): replace the device hub when emulator camera support changes by @juliusmarminge in pingdotgg/t3code#39764
* fix(desktop): Cmd+T opens the new-tab menu from a focused browser page by @juliusmarminge in pingdotgg/t3code#39769
* fix(server): port refusals survive T3 Connect's relay by @juliusmarminge in pingdotgg/t3code#39763
* fix(server): Antigravity links and discovers skills from skills.json by @mameli in pingdotgg/t3code#39765
* fix(desktop): WSL backend honors T3CODE_HOME from the distro's login shell by @juliusmarminge in pingdotgg/t3code#39771
* fix(server): pull_request_create opens a draft PR as a draft on GitHub and Azure by @juliusmarminge in pingdotgg/t3code#39772
* fix(server): Antigravity wake runs accept steers again by @juliusmarminge in pingdotgg/t3code#39767
* fix(server): keep DeepSeek ACP probes out of session history by @crisxuan in pingdotgg/t3code#39733
* fix(server): idle threads compact while a delegated task runs by @juliusmarminge in pingdotgg/t3code#39766
* fix(mobile): a settings row an older environment left mixed can be set off by @not-compromised in pingdotgg/t3code#39755
* feat: secret cards get a show/hide toggle and multi-value fields by @gabrielelpidio in pingdotgg/t3code#31257
* fix(ssh): a slow remote server keeps its SSH forward on reconnect by @juliusmarminge in pingdotgg/t3code#39802
* fix(antigravity): a scheduled wake keeps its run open instead of looking finished by @juliusmarminge in pingdotgg/t3code#39806
* fix(ssh): reconnect stops waiting on a remote server that is shutting down by @juliusmarminge in pingdotgg/t3code#39807
* fix(web): open PDF attachments no longer reload while the agent works by @juliusmarminge in pingdotgg/t3code#39815
* perf(linear): overlap issue details and viewer reads by @Adamulek123 in pingdotgg/t3code#39801
* fix(linear): scope issue numbers to the named team by @Adamulek123 in pingdotgg/t3code#39809
* fix(gitlab): pull_request_create opens a draft MR as a draft by @aravhawk in pingdotgg/t3code#39817
* fix(web): scrolling a PR description no longer moves focus to the condensed header by @juliusmarminge in pingdotgg/t3code#39840
* feat(cli): thread show reports why the latest run failed by @juliusmarminge in pingdotgg/t3code#39849

## New Contributors
* @mameli made their first contribution in pingdotgg/t3code#39765
* @crisxuan made their first contribution in pingdotgg/t3code#39733

**Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261120.4994...v0.1.12-nightly.20261120.5009

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261120.5009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants