You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): keep DeepSeek ACP probes out of session history - #39733
T3 Code's ACP provider probe creates a session to discover models and check readiness. DeepSeek Harness persists that session before it receives a prompt and does not advertise session/delete, so each uncached probe can add an empty “Untitled” entry to DeepSeek Harness Desktop.
To reproduce on macOS with T3 Code 0.1.11 and DeepSeek Harness 0.2.2-rc.5, add a local ACP provider with dsh --profile acp, refresh the provider, and inspect the DeepSeek Harness history.
Change
For DeepSeek Harness ACP probes, pass a final --patch overlay that writes session logs to a scoped temporary directory and disables the shared session-title cache for that process. Keep the existing DeepSeek home so the probe uses the configured model providers and credentials. The probe scope removes the temporary directory when it closes.
Scope
Follow-up to #25397 for DeepSeek Harness. The earlier fix cleans up probes through ACP deletion where the agent supports it. This small server-only fix uses the existing local ACP integration and applies the overlay only to dsh ACP probes.
Verification
The new regression test fails on the base branch because the probe launches without the history overlay. It passes with the fix and verifies that the temporary directory is removed after the probe.
Ran two probes through the T3 server probe function against the real DeepSeek Harness 0.2.2-rc.5 executable with an isolated DSH_HOME. Both revisions reported ready=true, canDelete=false, the same deepseek-v4-flash model, and the same reasoning_effort option. No model prompt was sent.
Build
Shared session logs after probe 1 / 2
Shared title-cache records after probe 1 / 2
Base
1 / 2
1 / 2
With fix
0 / 0
0 / 0
vp run check:changed origin/main --concurrency 2 passed formatting, lint, both Knip phases, generated GraphQL, type checking for 10 affected packages, and 39 tests. The dedicated ACP probe and driver suites also passed all 37 tests.
Implemented with GPT-6.2-Sol in the Codex harness.
Reviewing files that changed from the base of the PR and between 1ddd285 and c83d979.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
For DeepSeek Harness ACP probes, the probe now creates a temporary history patch and starts the runtime with it. The patch redirects session persistence to a temporary directory and disables the projection cache. The probe removes the directory when its scope closes.
Changes: Probe history isolation
Layer / File(s)
Summary
Prepare and use temporary history patch packages/provider-acp-registry/src/server/probe.ts, packages/provider-acp-registry/src/server/driver.ts, apps/server/src/provider/AcpRegistryProbe.test.ts
The probe detects matching DeepSeek Harness ACP invocations, writes a patch that redirects session persistence and disables the projection cache, then starts the runtime with the patched spawn. The driver provides filesystem and path services. A live test checks the patch contents and temporary-directory cleanup.
This change keeps DeepSeek Harness ACP readiness and model-discovery probes from writing session history. The behavior is limited to dsh ACP probes, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: DeepSeek Harness ACP probes are kept out of session history. The changeset adds a temporary --patch overlay for dsh ACP probes that redirects session logs to a scoped …
Description check
The description follows the template. It has Problem, Change, Scope, and Verification sections with substantive content. The Problem section gives the cause and reproduction steps with versions. The C…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: DeepSeek Harness ACP probes are kept out of session history. The changeset adds a temporary --patch overlay for dsh ACP probes that redirects session logs to a scoped temp directory and disables the title cache, which matches the title. The title follows the conventional commit format and is specific enough for a teammate scanning history.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope, and Verification sections with substantive content. The Problem section gives the cause and reproduction steps with versions. The Change section explains the overlay and the scoped temp directory. The Scope section links the follow-up to #25397 and explains why the change is server-only. The Verification section lists a regression test, real-executable probe results with a before/after table, and the repo check run. The template's note about the agent model and harness is present. The description does not link a GitHub issue for the bug, though the template asks for one or an explanation of why none is needed. That is a minor gap.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Add real dsh 0.2.2-rc.5 as a Local ACP provider using --profile acp, then refresh provider status twice. Each side uses fresh T3 and DeepSeek state on Linux, Chromium at 1280×800, light theme, without DeepSeek credentials.
Recordings are cropped to exclude the machine selector; the head recording also masks the temporary executable path.
Not shown:
DeepSeek Harness Desktop's history UI was not inspected because it is unavailable on Linux. Persistent history was verified through the real dsh ACP session/list and T3's Native sessions UI.
Authenticated DeepSeek conversation execution was not exercised; this reproduction required no credentials or model turn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
T3 Code's ACP provider probe creates a session to discover models and check readiness. DeepSeek Harness persists that session before it receives a prompt and does not advertise
session/delete, so each uncached probe can add an empty “Untitled” entry to DeepSeek Harness Desktop.To reproduce on macOS with T3 Code 0.1.11 and DeepSeek Harness 0.2.2-rc.5, add a local ACP provider with
dsh --profile acp, refresh the provider, and inspect the DeepSeek Harness history.Change
For DeepSeek Harness ACP probes, pass a final
--patchoverlay that writes session logs to a scoped temporary directory and disables the shared session-title cache for that process. Keep the existing DeepSeek home so the probe uses the configured model providers and credentials. The probe scope removes the temporary directory when it closes.Scope
Follow-up to #25397 for DeepSeek Harness. The earlier fix cleans up probes through ACP deletion where the agent supports it. This small server-only fix uses the existing local ACP integration and applies the overlay only to
dshACP probes.Verification
The new regression test fails on the base branch because the probe launches without the history overlay. It passes with the fix and verifies that the temporary directory is removed after the probe.
Ran two probes through the T3 server probe function against the real DeepSeek Harness 0.2.2-rc.5 executable with an isolated
DSH_HOME. Both revisions reportedready=true,canDelete=false, the samedeepseek-v4-flashmodel, and the samereasoning_effortoption. No model prompt was sent.vp run check:changed origin/main --concurrency 2passed formatting, lint, both Knip phases, generated GraphQL, type checking for 10 affected packages, and 39 tests. The dedicated ACP probe and driver suites also passed all 37 tests.Implemented with GPT-6.2-Sol in the Codex harness.