Skip to content

fix(antigravity): honor the saved thinking level in text generation - #39720

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
Lucenx9:fix/antigravity-text-generation-effort
Nov 20, 2026
Merged

juliusmarminge merged 2 commits into
pingdotgg:mainfrom
Lucenx9:fix/antigravity-text-generation-effort

Conversation

@Lucenx9

@Lucenx9 Lucenx9 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Problem

Antigravity text helpers ignore the thinking level saved in the text-generation model picker. A title configured with Low can run at the runtime's High default. The same helper generates commit messages, branch names and PR descriptions.

Change

After selecting the model, apply the saved thinking level if the active session advertises it. Missing, obsolete, and already-matching selections send no update. If ACP rejects a thinking change as invalid, the helper continues with the native level.

Scope

Small bug fix in the server-side text helper. A targeted search found related conversation and delegation work but no equivalent text-generation fix.

Verification

The focused test drives the title generator with an isolated ACP runtime fixture. The assertion reads the effective level when the prompt starts.

Title generation request Before After
Saved Low, native default High High Low
Saved Low, option appears after a model switch High Low
No choice, unavailable choice, or level already active High High, no write
ACP rejects a previously advertised choice First candidate aborts the helper Title generation succeeds at High

The focused regression failed on base and passes after the fix. The standalone replay called the production helper with a simulated ACP runtime and never sent a live model turn. fast-check passed 120 generated cases and Jazzer.js completed 160 bounded runs on that same seam.

Fallow and CodeScene advisory gates flagged added complexity on a two-file snapshot. Fallow's dependency coverage was limited in that snapshot. Checks ran on Linux.

The full Stryker rerun reached its time limit. A targeted rerun killed all 4 mutants in the ACP rejection check. The isolated vp run check:changed --concurrency 1 rerun passed all 41 tests, format, lint, both Knip stages, GraphQL and typecheck. The same check passed after rebasing onto df09ced. Normal commit hooks passed.

Independent reviews: Gemini 4 Neon on Antigravity (medium) and Opus 5.5 (high) approved the code.

Reviewed with sol-loop: 2 rounds with GPT-6.2 Sol on high. Sol verdict: approved.

Created with GPT-6.2 Sol in Codex through T3 Code.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 13:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T13:35:23.101660Z 2930841 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

After model selection, Antigravity text generation checks saved thinking-level settings against the selected model’s available options. It applies a differing, allowed string value and ignores ACP invalid-parameter rejections. Tests cover model selection and update outcomes.

Changes: Antigravity thinking-level selection

Layer / File(s) Summary
Apply saved thinking level after model selection
apps/server/src/textGeneration/AntigravityTextGeneration.ts, apps/server/src/textGeneration/AntigravityTextGeneration.test.ts
The generation flow applies an eligible saved thinking level after model selection and ignores ACP invalid-parameter rejections. Tests cover default selection, model switching, unavailable values, and rejected updates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#20979: Changes how Antigravity ACP sessions apply saved selections through the same configuration and helper flow.

Suggested labels: bugfix

Suggested reviewers: juliusmarminge, t3dotgg, macroscopeapp

Merge Risk: Minimal · up to 5ab7c

Antigravity text-generation helpers now use the thinking level saved in the model picker when the selected model offers it, and fall back to the native level otherwise. No merge-blocking risk was found in the reviewed change.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the fix in the Antigravity text-generation path: the saved thinking level is now applied during text generation. It matches the changeset, which applies the saved thinking option after…
Description check Passed The description follows the repository template. It has Problem, Change, Scope, and Verification sections, and the title is a conventional commit. The Problem section explains the bug and expected beh…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the fix in the Antigravity text-generation path: the saved thinking level is now applied during text generation. It matches the changeset, which applies the saved thinking option after model selection in AntigravityTextGeneration.ts and adds tests for that behavior. It follows the conventional commit format and is specific enough for a reader scanning history.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope, and Verification sections, and the title is a conventional commit. The Problem section explains the bug and expected behavior. The Change section explains the fix and edge cases. The Scope section says the change is a small bug fix in the server-side text helper, but it does not link an issue or explain why no issue is needed beyond calling it small. The Verification section gives a detailed table and test results. It also lists the tests and checks run and states the environment (Linux). It does not state anything the author could not check, although the Stryker full run timed out and is mentioned. It also includes the agent/model attribution line that the template asks for. The main gap is the missing issue link or explicit justification for no issue in Scope.

Resolution

Optional: link the issue that shows the bug, or state briefly why a small obvious fix needs no issue, in the Scope section.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2930841 and 5ab7c04.

Files selected for processing: 1

  • apps/server/src/textGeneration/AntigravityTextGeneration.test.ts
Files with no reviewable changes: 1

  • apps/server/src/textGeneration/AntigravityTextGeneration.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Ran both commits in isolated Linux web apps using Chromium at 1280×800, light theme, and Antigravity 1.5.13 with Gemini API-key authentication. Saved Gemini 4 Neon / High under Settings → Threads → Text generation model, then sent “Add a dark mode toggle to the settings page” using Replay Showcase and waited for the real Antigravity title helper.

Before After
df09ced768 5ab7c0431c
Before: saved High but ACP prompts at Low After: ACP acknowledges High before prompting
App recording App recording
Recorded ACP exchange Recorded ACP exchange

Images combine real Settings crops with condensed recorded ACP traffic. Base selects the model and immediately prompts while the runtime reports Low. Head sends thought_level=high, receives High in configOptions, then prompts. Both complete title generation. Title wording itself is not the proof.

Host labels and streaming workspace paths are redacted in recordings. Captures were inspected before upload.

ACP recorder · Reproduction procedure and capture details

Not shown:

  • Invalid-choice fallback: the real runtime accepted High, so ACP invalid-parameter rejection and continuation at the native level were not induced.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 20, 2026
@juliusmarminge
juliusmarminge merged commit e74b795 into pingdotgg:main Nov 20, 2026
58 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 20, 2026
AIdoesmyjob pushed a commit to AIdoesmyjob/t3code that referenced this pull request Nov 20, 2026
…ingdotgg#39720)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit e74b795)
HNRow pushed a commit to HNRow/r3code that referenced this pull request Nov 20, 2026
…ingdotgg#39720)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit e74b795)
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 20, 2026
**v0.1.12-nightly.20261120.5009** · 30 changes from 9 contributors

- **Secret cards.** Enter multiple secret values in one card and show or hide masked values on the web.
- **Shared Antigravity skills.** Use Antigravity skills registered in shared or external directories.
- **Thread failure reasons.** See why the latest thread run failed when checking it from the command line.
- **Draft pull requests.** Create draft pull requests directly without briefly announcing them as ready for review or starting unnecessary CI runs.
- **Azure DevOps Bugs.** Read and edit Bug descriptions stored in Repro Steps from Issues.
- **Stable file previews.** Keep HTML previews and attachments open while agents work, without losing form input to unnecessary reloads.
- **T3 Connect port forwarding.** Forward ports to your machine when connected to another machine through T3 Connect.

### Plus 21 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(server): Claude gateway cooldown survives an untyped SDK rejection by @juliusmarminge in pingdotgg/t3code#39695
* fix(release): Windows resource monitor starts without the Visual C++ runtime by @jieyuexing in pingdotgg/t3code#39683
* fix(server): turn authorship works on Git before 2.36 by @juliusmarminge in pingdotgg/t3code#39702
* fix(mobile): new thread says the host has no model instead of asking to connect by @juliusmarminge in pingdotgg/t3code#39713
* fix(antigravity): keep truncated command text valid Unicode by @Lucenx9 in pingdotgg/t3code#39697
* fix(antigravity): honor the saved thinking level in text generation by @Lucenx9 in pingdotgg/t3code#39720
* fix(azure-devops): read and edit a Bug's text in Repro Steps by @juliusmarminge in pingdotgg/t3code#39738
* fix(web): stop reloading unchanged file previews during agent commands by @juliusmarminge in pingdotgg/t3code#39736
* fix(server): a released provider session ends its tool call nodes too by @jieyuexing in pingdotgg/t3code#39734
* fix(server): watch_pull_request says a merge or close wakes the agent by @juliusmarminge in pingdotgg/t3code#39739
* fix(server): replace the device hub when emulator camera support changes by @juliusmarminge in pingdotgg/t3code#39764
* fix(desktop): Cmd+T opens the new-tab menu from a focused browser page by @juliusmarminge in pingdotgg/t3code#39769
* fix(server): port refusals survive T3 Connect's relay by @juliusmarminge in pingdotgg/t3code#39763
* fix(server): Antigravity links and discovers skills from skills.json by @mameli in pingdotgg/t3code#39765
* fix(desktop): WSL backend honors T3CODE_HOME from the distro's login shell by @juliusmarminge in pingdotgg/t3code#39771
* fix(server): pull_request_create opens a draft PR as a draft on GitHub and Azure by @juliusmarminge in pingdotgg/t3code#39772
* fix(server): Antigravity wake runs accept steers again by @juliusmarminge in pingdotgg/t3code#39767
* fix(server): keep DeepSeek ACP probes out of session history by @crisxuan in pingdotgg/t3code#39733
* fix(server): idle threads compact while a delegated task runs by @juliusmarminge in pingdotgg/t3code#39766
* fix(mobile): a settings row an older environment left mixed can be set off by @not-compromised in pingdotgg/t3code#39755
* feat: secret cards get a show/hide toggle and multi-value fields by @gabrielelpidio in pingdotgg/t3code#31257
* fix(ssh): a slow remote server keeps its SSH forward on reconnect by @juliusmarminge in pingdotgg/t3code#39802
* fix(antigravity): a scheduled wake keeps its run open instead of looking finished by @juliusmarminge in pingdotgg/t3code#39806
* fix(ssh): reconnect stops waiting on a remote server that is shutting down by @juliusmarminge in pingdotgg/t3code#39807
* fix(web): open PDF attachments no longer reload while the agent works by @juliusmarminge in pingdotgg/t3code#39815
* perf(linear): overlap issue details and viewer reads by @Adamulek123 in pingdotgg/t3code#39801
* fix(linear): scope issue numbers to the named team by @Adamulek123 in pingdotgg/t3code#39809
* fix(gitlab): pull_request_create opens a draft MR as a draft by @aravhawk in pingdotgg/t3code#39817
* fix(web): scrolling a PR description no longer moves focus to the condensed header by @juliusmarminge in pingdotgg/t3code#39840
* feat(cli): thread show reports why the latest run failed by @juliusmarminge in pingdotgg/t3code#39849

## New Contributors
* @mameli made their first contribution in pingdotgg/t3code#39765
* @crisxuan made their first contribution in pingdotgg/t3code#39733

**Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261120.4994...v0.1.12-nightly.20261120.5009

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261120.5009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants