Skip to content

Fix for NormalizePath resolving IntDir based on current working directory (#4108) - #4161

Merged
kmelmon merged 1 commit into
microsoft:0.60-stablefrom
jagorrin:4108fix
Feb 21, 2020
Merged

kmelmon merged 1 commit into
microsoft:0.60-stablefrom
jagorrin:4108fix

Conversation

@jagorrin

@jagorrin Jason Gorringe (jagorrin) commented Feb 21, 2020 •

Copy link
Copy Markdown
Contributor

To bring this into the 0.60 branch.

Microsoft Reviewers: Open in CodeFlow

…tory (#4108)

* Fix issues with relative IntDir breaking builds

* formatting

* Change files

* Re-order path resolution calls. NormalizePath/NormalizeDirectory are the culprits here -- they normalize to an absolute path based on current working directory.
@jagorrin
Jason Gorringe (jagorrin) requested a review from a team as a code owner February 21, 2020 17:57
@ghost ghost added the vnext label Feb 21, 2020
@kmelmon
kmelmon self-requested a review February 21, 2020 22:19

@kmelmon kmelmon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kmelmon
kmelmon merged commit 5641316 into microsoft:0.60-stable Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants