Skip to content

Fix for NormalizePath resolving IntDir based on current working directory - #4108

Merged
Nick Gerleman (NickGerleman) merged 4 commits into
microsoft:masterfrom
aschultz:users/aschultz/build
Feb 18, 2020
Merged

Nick Gerleman (NickGerleman) merged 4 commits into
microsoft:masterfrom
aschultz:users/aschultz/build

Conversation

@aschultz

@aschultz Aaron Schultz (aschultz) commented Feb 15, 2020 •

Copy link
Copy Markdown
Contributor
Microsoft Reviewers: Open in CodeFlow

…the culprits here -- they normalize to an absolute path based on current working directory.
@aschultz Aaron Schultz (aschultz) changed the title Fix for relative IntDir breaking builds in some situations Fix for NormalizePath resolving IntDir based on current working directory Feb 15, 2020
Comment thread vnext/ReactUWP/ReactUWP.vcxproj Resolved
Comment thread vnext/ReactUWP/ReactUWP.vcxproj Resolved
@aschultz

Copy link
Copy Markdown
Contributor Author

Nick Gerleman (@NickGerleman) Mind merging this for me?

@NickGerleman
Nick Gerleman (NickGerleman) merged commit acd2f6c into microsoft:master Feb 18, 2020
@aschultz
Aaron Schultz (aschultz) deleted the users/aschultz/build branch February 19, 2020 00:48
kmelmon pushed a commit that referenced this pull request Feb 21, 2020
…tory (#4108) (#4161)

* Fix issues with relative IntDir breaking builds

* formatting

* Change files

* Re-order path resolution calls. NormalizePath/NormalizeDirectory are the culprits here -- they normalize to an absolute path based on current working directory.

Co-authored-by: Aaron Schultz <codedclarity@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants