Repository navigation
docs: run project commands through vp - #3679
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Documents and runs every project command through the Vite+ CLI, following #3673 and #3678.
Changes
README.md,CONTRIBUTING.mdand.github/copilot-instructions.mdusevp install,vp run <script>andvp exec tsc --noEmitinstead ofpnpm. Each now asks contributors to install the Vite+ CLI, which downloads the pnpm version pinned indevEngines.i18n:checkandi18n:lintsteps inlint.ymlusevp run, like the rest of the workflow.vp stageddirectly. Husky putsnode_modules/.binonPATH, so it does not need a globalvp..github/copilot-instructions.mdkeeps only guidance an agent cannot read from the repository: setup, the main commands, the pre-finish checks, two gotchas, and the project philosophy. It drops the file map and version list (covered byARCHITECTURE.mdandpackage.json) and stale claims: Node 24, a separatetscstep (vp run checktype-checks), pre-existing lint warnings, timezone snapshot drift (vitest.config.mtsforcesTZ=UTC), and a wrong codegen output path. It also lists GitLab.pnpm <script>commands now namevp run <script>.Mentions of pnpm itself (the store, lockfile,
pnpm listin the packaging check, and the visual test container inscripts/visual.sh) are unchanged, because pnpm remains the package manager underneathvp install.Testing
vp install --frozen-lockfileuses pnpm 12.18.0 and finds the lockfile up to date.vp exec tsc --noEmitpasses.vp run test -upasses-uthrough to Vitest; all 2194 tests pass and no snapshots change.vp stagedon this commit.vp run checkpasses.