Skip to content

build: replace concurrently with vp run tasks - #3673

Merged
afonsojramos merged 2 commits into
mainfrom
chore/vp-run-tasks
Nov 11, 2026
Merged

afonsojramos merged 2 commits into
mainfrom
chore/vp-run-tasks

Conversation

@afonsojramos

Copy link
Copy Markdown
Member

Runs the parallel development scripts with the Vite+ task runner instead of concurrently, and removes scripts/dev.mjs.

Changes

  • dev, devtools and i18n:check call vp run --log labeled <group>. Each group is a run.tasks entry in vite.config.mts whose members are independent dependsOn tasks, which vp run starts concurrently. vp run accepts a single task, so the group's own command is a no-op.
  • codegen:watch calls graphql-codegen directly instead of going through pnpm.
  • A serve-only Vite plugin prepares the branded macOS Electron bundle once per dev server and sets ELECTRON_OVERRIDE_DIST_PATH, which scripts/dev.mjs did before. Plain vp dev now gets the branded bundle too.
  • applyDevElectronBundle() clears the electron module from the require cache, because the package resolves its binary path once on first load. It also clears the override before preparing, so a dev server restart resolves the installed Electron instead of the prepared copy.
  • Removes concurrently and its transitive dependencies.

Behavior differences

  • Output lines carry vp run labels such as [gitify#dev:renderer] instead of [vite].
  • In dev, a crashed codegen watcher now stops Vite too. i18n:check keeps its fail-fast behavior.

Testing

On macOS:

  • pnpm dev: Electron launches from ~/Library/Caches/gitify-dev, including a cold bundle rebuild, after a main-process rebuild, and after a vite.config.mts restart with an invalidated bundle marker. Ctrl+C stops every process.
  • pnpm devtools: Vite, codegen, Electron and React DevTools start and stop together.
  • pnpm i18n:check: passes, and a failing member stops the others with exit code 1.
  • pnpm check and pnpm test (2191 tests) pass.

Windows and Linux were not tested; applyDevElectronBundle() is a no-op there.

@afonsojramos
afonsojramos requested a review from setchy as a code owner November 10, 2026 17:44
@github-actions github-actions Bot added build Build, action or package manager changes dependency Dependency updates labels Nov 10, 2026
@sonarqubecloud

Copy link
Copy Markdown

@afonsojramos
afonsojramos merged commit e1c32d1 into main Nov 11, 2026
19 checks passed
@afonsojramos
afonsojramos deleted the chore/vp-run-tasks branch November 11, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build, action or package manager changes dependency Dependency updates

Development

Successfully merging this pull request may close these issues.

2 participants