Repository navigation
build: replace concurrently with vp run tasks - #3673
Merged
Merged
Conversation
|
setchy
approved these changes
Nov 10, 2026
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Runs the parallel development scripts with the Vite+ task runner instead of
concurrently, and removesscripts/dev.mjs.Changes
dev,devtoolsandi18n:checkcallvp run --log labeled <group>. Each group is arun.tasksentry invite.config.mtswhose members are independentdependsOntasks, whichvp runstarts concurrently.vp runaccepts a single task, so the group's own command is a no-op.codegen:watchcallsgraphql-codegendirectly instead of going throughpnpm.ELECTRON_OVERRIDE_DIST_PATH, whichscripts/dev.mjsdid before. Plainvp devnow gets the branded bundle too.applyDevElectronBundle()clears theelectronmodule from the require cache, because the package resolves its binary path once on first load. It also clears the override before preparing, so a dev server restart resolves the installed Electron instead of the prepared copy.concurrentlyand its transitive dependencies.Behavior differences
vp runlabels such as[gitify#dev:renderer]instead of[vite].dev, a crashed codegen watcher now stops Vite too.i18n:checkkeeps its fail-fast behavior.Testing
On macOS:
pnpm dev: Electron launches from~/Library/Caches/gitify-dev, including a cold bundle rebuild, after a main-process rebuild, and after avite.config.mtsrestart with an invalidated bundle marker. Ctrl+C stops every process.pnpm devtools: Vite, codegen, Electron and React DevTools start and stop together.pnpm i18n:check: passes, and a failing member stops the others with exit code 1.pnpm checkandpnpm test(2191 tests) pass.Windows and Linux were not tested;
applyDevElectronBundle()is a no-op there.