Skip to content

mangowc: update to 0.18.6 - #63318

Open
juandmcr wants to merge 1 commit into
void-linux:masterfrom
juandmcr:update-mangowc
Open

juandmcr wants to merge 1 commit into
void-linux:masterfrom
juandmcr:update-mangowc

Conversation

@juandmcr

@juandmcr juandmcr commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • i686
    • aarch64 (crossbuild)
    • aarch64-musl (crossbuild)
    • armv7l (crossbuild)
    • armv7l-musl (crossbuild)
    • armv6l (crossbuild)
    • armv6l-musl (crossbuild)

Comment thread srcpkgs/mangowc/template
Comment on lines 18 to 19
build_options="xwayland"
desc_option_xwayland="Enable Xwayland support"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build_options="xwayland"
desc_option_xwayland="Enable Xwayland support"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally added that switch, but it doesn't do anything except pulling in an optional dependency

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right.
I remember seeing someone complaining (in a void-packages PR I believe) a while ago that they didn't use xwayland and wanted an option to disable it in mangowc tho. I guess I never really looked into how that option was implemented after that...

Couldn't we keep it and fix this by passing the appropriate meson argument so that xwayland can actually be disabled at build time? Something like this:

Suggested change
build_options="xwayland"
desc_option_xwayland="Enable Xwayland support"
configure_args="$(vopt_feature xwayland)"
depends="$(vopt_if xwayland xorg-server-xwayland)"
build_options="xwayland"
desc_option_xwayland="Enable Xwayland support"

That way, mango should actually be built without xwayland support when the option is disabled, if I'm not mistaken. I've just tried it and it seems okay.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@realcharmer Sorry to bother you, but what do you think about adding this to the template? (I'll have to update to the latest mango version after this too)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Thanks for taking care of this Juan.

@juandmcr
juandmcr force-pushed the update-mangowc branch 2 times, most recently from a3373b8 to 6ca9dd4 Compare November 18, 2026 16:20
@juandmcr juandmcr changed the title mangowc: update to 0.18.4 mangowc: update to 0.18.6 Nov 18, 2026
@juandmcr

Copy link
Copy Markdown
Contributor Author

Updated to 0.18.6 and built as described in the original PR message (built with and without xwayland too since I do use it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants