Repository navigation
Conversation
| build_options="xwayland" | ||
| desc_option_xwayland="Enable Xwayland support" |
There was a problem hiding this comment.
| build_options="xwayland" | |
| desc_option_xwayland="Enable Xwayland support" |
There was a problem hiding this comment.
I originally added that switch, but it doesn't do anything except pulling in an optional dependency
There was a problem hiding this comment.
Oh, you're right.
I remember seeing someone complaining (in a void-packages PR I believe) a while ago that they didn't use xwayland and wanted an option to disable it in mangowc tho. I guess I never really looked into how that option was implemented after that...
Couldn't we keep it and fix this by passing the appropriate meson argument so that xwayland can actually be disabled at build time? Something like this:
| build_options="xwayland" | |
| desc_option_xwayland="Enable Xwayland support" | |
| configure_args="$(vopt_feature xwayland)" | |
| depends="$(vopt_if xwayland xorg-server-xwayland)" | |
| build_options="xwayland" | |
| desc_option_xwayland="Enable Xwayland support" |
That way, mango should actually be built without xwayland support when the option is disabled, if I'm not mistaken. I've just tried it and it seems okay.
There was a problem hiding this comment.
@realcharmer Sorry to bother you, but what do you think about adding this to the template? (I'll have to update to the latest mango version after this too)
There was a problem hiding this comment.
Fine by me. Thanks for taking care of this Juan.
a3373b8 to
6ca9dd4
Compare
6ca9dd4 to
7dfc7de
Compare
|
Updated to 0.18.6 and built as described in the original PR message (built with and without xwayland too since I do use it) |
Testing the changes
Local build testing