This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Conversation
Use Electron 45 with exact-runtime snapshots and Node 24 native tooling. Match macOS native appearance to the focused terminal background, preserve native hiddenInset controls, and migrate clipboard access through main. Add the canonical verification hook and update supported platform builds. BREAKING CHANGE: Requires macOS 13+, Windows 10+ or supported 64-bit Linux. Windows ia32 and Linux armv7l are no longer built. Developers need Node 24 and pnpm 10.33.0. Rebuild native plugins for Electron 45 and migrate renderer clipboard calls to a main-process bridge or navigator.clipboard; main-process clipboard APIs are asynchronous and native file references use text/uri-list. Existing Hyper configuration needs no migration.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyper's old Electron runtime and native light appearance on dark terminal themes leave its macOS traffic lights looking out of place on Golden Gate. Update to Electron 45.0.0 and derive native macOS appearance from the focused terminal background, including live theme changes. Native
hiddenInsetcontrols, transparency, plugin window decoration, and the 76-point header reservation are preserved.This also installs Electron's binary explicitly, generates version-matched snapshots, updates Node 24 native-module tooling, migrates clipboard operations through the existing main-process remote bridge, and updates the 64-bit CI matrix.
node-pty1.1.0 already contains the pipe-cleanup behavior preserved by Hyper's previous patch.Verification
pnpm install --frozen-lockfilepassed with Node 24.14.1 / pnpm 10.33.0.pnpm run verifypassed, including the installed pre-commit hook: formatting/lint, 12 unit tests, production build and TypeScript compilation. A deliberate syntax error blocked a commit and left HEAD unchanged; no hooks were bypassed. Existing pre-push tests remain enabled.Native-control evidence and limits
The after desktop crop is explicitly from the terminal-free reproduction using the production appearance helper. Desktop automation blocks
co.zeit.hyper, so direct packaged-window after captures and native-button pointer/hover checks remain unverified. Renderer screenshots do not include native chrome. See the verification record and reproducible capture command.Tab close can still expose xterm's existing canvas disposal exception (
onRequestRedrawon an undefined renderer). A minimal disposal reproduces the same exception on both Electron 22.3.25 and 45.0.0; shell termination succeeds. This unrelated implementation is unchanged, and the functional run is not represented as free of renderer exceptions.Upstream Node CI has not created a run for PR head
303ac1493cf0cf299970a2471396900cebf404a9(Actions API check). Windows/Linux/Intel macOS builds therefore remain unverified. Repository Actions-policy inspection returns HTTP 403 to this account, so maintainer assistance is needed to check why the matrix has not started. Socket dependency scans passed; the internal security review concluded neutral. These provider results are separate from the passing local checks.BREAKING CHANGE: Requires macOS 13+, Windows 10+ or supported 64-bit Linux. Windows ia32 and Linux armv7l are no longer built. Developers need Node 24 and pnpm 10.33.0. Rebuild native plugins for Electron 45 and migrate renderer clipboard calls to a main-process bridge or navigator.clipboard; main-process clipboard APIs are asynchronous and native file references use text/uri-list. Existing Hyper configuration needs no migration.