Skip to content

Mvp/skeleton - #3

Merged
timmyichen merged 6 commits into
timmyichen:mvp/skeletonfrom
Zeko369:mvp/skeleton
Oct 21, 2019
Merged

timmyichen merged 6 commits into
timmyichen:mvp/skeletonfrom
Zeko369:mvp/skeleton

Conversation

@Zeko369

@Zeko369 Zeko369 commented Oct 21, 2019

Copy link
Copy Markdown
  • [] I have read Chapter's contributing guidelines.
  • [] My pull request has a descriptive title (not a vague title like Update README.md).
  • [] My pull request targets the master branch of Chapter.

Closes #XXXXX

Comment thread README.md Resolved

@timmyichen timmyichen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Just left a request for improving the contributor experience.

@timmyichen timmyichen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thanks :)

@timmyichen
timmyichen merged commit 4d2cdd0 into timmyichen:mvp/skeleton Oct 21, 2019
timmyichen added a commit that referenced this pull request Oct 21, 2019
* basic app skeleton

* update readme

* remove body parser

* tsconfig target esnext

* nodemon -> dev dep

* api route examples

* custom typing for responseErrorHandler

* oops fix speccy location

* tslint -> eslint

* add dockerfile, update installation instructions in README

* emptyline at end of eslintignore

* Revert "add dockerfile, update installation instructions in README"

This reverts commit 8075dc4.

* Revert "Revert "add dockerfile, update installation instructions in README""

This reverts commit cf502e5.

* fix dockerfile and use npm ci

* update readme, update nodemon watch files

* add next to the docs

* Add suggestions/fixes to skeleton (#1)

* chore: added speccy to docker compose dev environment

* chore: added speccy to dev deps, added/updated scripts, fixed husky warning

* test: added test for SomeComponent

* docs: updated scripts and added testing

* chore: setup jest testing

* no more dockerfile, update docs

* add js and jsx extensions to configs

* chore: removed unnecessary network, switched to using top level volume (#2)

* Mvp/skeleton (#3)

* fix(setup) Add note for linux users about docker-compose problem with PWD

* fix(client) Use named functions for components

* fix(setup) Turn of ts noImplicitAny

* fix(setup) Use es6 imports in next config

* fix(docker) Remove top level volumes

* fix(setup) add newline to end of package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants