Repository navigation
README: use the config keys that init writes (cypress_project_dir) - #22
Open
jochen-testingbot wants to merge 2 commits into
Open
jochen-testingbot wants to merge 2 commits into
jochen-testingbot wants to merge 2 commits into
Conversation
The README told users to set 'cypress_proj_dir'; testingbot.json uses run_settings.cypress_project_dir, and credentials go in the auth section. Mention that start_tunnel defaults to true (needs Java) and update the docs link (301).
There was a problem hiding this comment.
🟡 Changes recommended
README.md incorrectly documents start_tunnel as a top-level key even though the CLI reads run_settings.start_tunnel, which could lead users to configure an ignored setting.
1 open issue
What changed in this PR
Updates the README to match the configuration generated and consumed by testingbot-cypress, clarifies tunnel behavior, and updates the Cypress documentation link.
Changes:
- Documents credentials under
authand the project directory underrun_settings.cypress_project_dir. - Explains that the tunnel is enabled by default, requires Java, and can be disabled for public sites.
- Replaces the outdated Cypress documentation URL.
| File | Summary | Review comment |
|---|---|---|
README.md |
Aligns configuration guidance, tunnel instructions, and documentation links with the current CLI behavior. | Nit: Document start_tunnel as run_settings.start_tunnel; the generated configuration places it under run_settings, and the CLI reads it from there. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of https://testingbot-team.atlassian.net/browse/TB-1008 (docs audit: run every SDK README snippet).
Running the README (npm 1.1.5,
node:22-bookworm-slim)npm install -g testingbot-cypress-cli,testingbot-cypress initandtestingbot-cypress runall work.cypress_proj_dir, butinitwritesrun_settings.cypress_project_dir. A reader who adds the key the README names gets a config the CLI ignores."start_tunnel": true. The tunnel needs Java, which the README only mentions in passing.Change (README only)
auth.key/auth.secretandrun_settings.cypress_project_dir.start_tunnel(defaults to true; set false for public sites; needs Java)./support/web-automate/cypress(the old URL 301s).Verification
The npm page only changes with a release. That is needs-jochen and low priority (README only).