Repository navigation
Conversation
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.8 MB, up 48.0 KB from 134.7 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Verified all nine findings from both reviews. Six are confirmed, one is refuted because the shared API client already retries transient failures, and two remain uncertain because the available contracts do not establish the required backend behavior. No findings overlap.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.command.ts:81 |
test-coverage |
claude | Registering warehouse enable with consent default No makes the existing hosted-consent inline snapshot fail because it omits this command. |
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.handler.ts:152 |
correctness |
claude | A nonempty partial status table list immediately fails --wait as a selection change, potentially rejecting healthy setup if table registration is incremental. |
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.handler.ts:145 |
error-handling |
claude | The table-error failure path reports only the overall setup status, omitting the failing table and obscuring why waiting stopped. |
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.handler.ts:93 |
correctness |
claude | An empty successful preview is passed through to consent and setup, and an accepted zero-table setup could satisfy the table-completion checks. |
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.errors.ts:9 |
test-maintenance |
codex | The five new Warehouse error tags are absent from the committed telemetry snapshot, causing the error-tag stability test to fail. |
| 🟡 MINOR | apps/cli/src/commands/warehouse/enable/enable.handler.ts:39 |
error-handling |
codex | Selection-conflict recovery guidance directs users to warehouse replication add/remove commands that do not exist. |
| ⚪ NIT | apps/cli/src/commands/warehouse/enable/enable.handler.ts:205 |
output-contract |
claude | The structured success payload omits selected_tables with --wait and instead exposes decoded status attributes at the top level, giving consumers two different selection representations. |
| ⚪ NIT | apps/cli/src/docs/docs-spec.tables.ts:213 |
consistency |
claude | The required --schema flag is missing from the completion-required table, so warehouse enable does not offer it as the required completion candidate. |
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/src/commands/warehouse/enable/enable.handler.ts:138(error-handling): A single temporary network error, 429, or 503 immediately aborts --wait because polling has no retry handling.
Refuted: Retries already exist below the handler. command-platform-api.layer.ts:62-70 constructs the shared API client with retry settings. packages/api/src/internal/client.ts:235 defaults to five retries; lines 242-256 classify GET transport failures, 429s, and 5xx responses as retryable; lines 341-366 apply backoff and Retry-After handling. Failures can surface after exhaustion or retry-policy limits, but ordinary single transient failures do not immediately abort waiting.
Stats
Claude findings: 7 · Codex findings: 2 · Confirmed: 6 · Refuted: 1 · Uncertain: 2
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Adds
supabase warehouse enable --schema <schema> [--table <table>]with hosted project selection, previewed table confirmation, and optional bounded synchronization waiting.Uses the shared v2 setup API in explicit enable mode. Structured output distinguishes accepted setup from completed initial synchronization; completion checks table identities, replication state, and DNS readiness.
Depends on https://github.com/supabase/platform/pull/41439. Deploy the API before releasing this command and refresh the generated client from the deployed specification afterward.
How to review
apps/cli/src/commands/warehouse/enable/withSIDE_EFFECTS.mdandenable.command.ts: check flags, hosted targeting, permissions, and the explanation that schema selection includes only existing eligible tables; future tables must be added separately.enable.handler.tsfrom preview through confirmation to setup. The selected tables and schema reminder appear before consent, and setup sends the confirmed table identities withmode: "enable".enable.integration.test.tsandenable.e2e.test.tsfor output, consent, waiting, and bookkeeping behavior. Reviewpackages/api/src/generated/last, focusing on the three Warehouse operations and their request/response contracts.