Skip to content

feat: Support graceful shutdown - #487

Merged
sbernauer merged 5 commits into
mainfrom
feat/graceful-shutdown
Nov 7, 2023
Merged

feat: Support graceful shutdown#487
sbernauer merged 5 commits into
mainfrom
feat/graceful-shutdown

Conversation

@sbernauer

@sbernauer sbernauer commented Nov 6, 2023 •
edited by lfrancke
Loading

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#357
Closes #489

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [x] Proper release label has been added

@sbernauer sbernauer self-assigned this Nov 6, 2023
@maltesander
maltesander self-requested a review November 6, 2023 15:22
maltesander
maltesander previously approved these changes Nov 6, 2023
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/modules/opa/pages/usage-guide/operations/graceful-shutdown.adoc Resolved
@sbernauer @maltesander
Update docs/modules/opa/pages/usage-guide/operations/graceful-shutdow…
0f87fb2 
…n.adoc

Co-authored-by: Malte Sander <contact@maltesander.com>
maltesander
maltesander approved these changes Nov 6, 2023
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer mentioned this pull request Nov 7, 2023
Closed
@sbernauer
sbernauer added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 11c7814 Nov 7, 2023
@sbernauer
sbernauer deleted the feat/graceful-shutdown branch November 7, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels

release/23.11.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make OPA telemetry opt-in

3 participants

@sbernauer @maltesander @lfrancke