Repository navigation
Conversation
AI-Assisted: yes (GPT-5.5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5222 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 393 393
Lines 98325 98342 +17
=======================================
+ Hits 79786 79802 +16
- Misses 18539 18540 +1
🚀 New features to boost your workflow:
|
guedou
force-pushed
the
fix-icmpv6-rfc4884-length
branch
from
October 7, 2026 13:39
097fcb6 to
65ef3c8
Compare
gpotter2
reviewed
Nov 11, 2026
| def post_build(self, p, pay): | ||
| p += pay | ||
| if (getattr(self, "ext", None) is not None and | ||
| getattr(self, "length", 0) == 0): |
gpotter2
reviewed
Nov 11, 2026
| if (getattr(self, "ext", None) is not None and | ||
| getattr(self, "length", 0) == 0): | ||
| # RFC 4884: padded original datagram length, in 64-bit words. | ||
| datagram_len = len(p) - len(raw(self.ext)) - 8 |
gpotter2
reviewed
Nov 11, 2026
| datagram_len = len(p) - len(raw(self.ext)) - 8 | ||
| if datagram_len > 0: | ||
| length = datagram_len // 8 | ||
| if length <= 255: |
Member
There was a problem hiding this comment.
Considering it's build, I'd let the chb fail.
gpotter2
requested changes
Nov 11, 2026
gpotter2
left a comment
Member
There was a problem hiding this comment.
Minor comments, the rest LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4353