Repository navigation
Fix IndexError/struct.error when scanning IPv6 Hop-by-Hop header for a Jumbo option - #5208
Open
AbdaullahAG wants to merge 1 commit into
Open
AbdaullahAG wants to merge 1 commit into
AbdaullahAG wants to merge 1 commit into
Conversation
Author
|
@gpotter2 hi , could you please approve the workflow run for this PR so the CI checks can complete? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5208 +/- ##
===========================================
- Coverage 78.59% 47.48% -31.12%
===========================================
Files 375 375
Lines 98482 98482
===========================================
- Hits 77403 46763 -30640
- Misses 21079 51719 +30640
🚀 New features to boost your workflow:
|
Fix an out-of-bounds read when parsing IPv6 options where an Option 194 (Jumbo Payload) payload is shorter than expected. AI-Assisted: yes (to find the bug, code written manually)
gpotter2
force-pushed
the
fix-jumbo-option-bounds
branch
from
November 11, 2026 17:13
1e0519f to
37857eb
Compare
gpotter2
approved these changes
Nov 11, 2026
gpotter2
enabled auto-merge (squash)
November 11, 2026 17:14
Member
|
Thanks for the PR ! sadly tests don't pass. |
gpotter2
disabled auto-merge
November 11, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IPv6.extract_paddinglooks for a Jumbo option in the Hop-by-Hop header withwhile offset <= len(data). When no Jumbo option is found andlen(data)equals an offset visited by the loop,data[offset]raisesIndexError. When an0xc2type byte is found with fewer than 6 bytes remaining,struct.unpackraisesstruct.error.scapy/scapy/layers/inet6.py
Lines 366 to 370 in 7daa15d
The loop now requires 6 bytes (type, length, 4-byte value) to remain. A regression test is added to
test/scapy/layers/inet6.uts.