Repository navigation
chore(native): decouple remaining compile-time assets and align right-panel tooltip rim - #474
Merged
Merged
Conversation
…-panel tooltip rim Vendors the two SnapShot sound assets and server target version inside apps/native/crates/app so zero compile-time includes escape apps/native, and updates right_panel::controls::tooltip_view to use theme_slot_clipped_background_layer matching settings/composer tooltips. Model: Antigravity coordinator
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes standalone compilation decoupling for
apps/nativeand resolves the non-blocking right-panel tooltip review note from PR #473:snap-shot-whoosh.mp3andsnap-shot-click.mp3underapps/native/crates/app/src/snapshot_capture/assets/TARGET_SERVER_VERSION(0.1.10) underapps/native/crates/app/src/updates/instead of readingapps/server/package.jsonright_panel::controls::tooltip_viewto wrapTooltipPopupwiththeme_slot_clipped_background_layerwhen gradient/rim layers are activeVerified: zero
../../../compile-time includes remain inapps/native/crates/,cargo clippy --workspace --all-targets -- -D warningsclean,t3-native244/244 pass.