Repository navigation
feat(native): wire Browser settings defaults & profiles for server-streamed preview (ST-BROWSER, PN-PREVIEW) - #460
Merged
Conversation
…reamed preview (ST-BROWSER, PN-PREVIEW)
rynfar
force-pushed
the
feat/native-browser-preview-defaults
branch
from
November 20, 2026 05:47
e3632a5 to
3804487
Compare
This was referenced Nov 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #99
Part of #249
Summary
Wires real
ST-BROWSERsettings controls for server-streamed preview defaults and profiles, verifies livePN-PREVIEWconsumption across new tabs, closed-tab fallbacks, and the device toolbar, and flipsST-BROWSERandPN-PREVIEWtodoneinapps/native/parity/LEDGER.md.Changes
crates/core/src/{client_settings.rs, preview.rs, preview/viewport.rs, settings/search.rs}):ClientSettingChangevariants, validation/sanitization, getters, and round-trip JSON persistence forbrowserDefaultViewport,browserDefaultZoomFactor,browserDefaultAppearance,browserProfiles(max 24, persistent-forced, built-in/duplicate/control-char filtered), andbrowserDefaultProfileId(incognito rejected back to"default"), matchingpackages/contracts/src/{settings.ts, preview.ts, browserProfile.ts}andBrowserDefaults.method::REPORT_PROFILES(preview.reportProfiles),normalize_zoom_level,zoom_label,viewport_select_value,next_unique_profile_name, andreport_profiles_payload.client_settings/tests.rs,preview/viewport.rs, andsettings/search.rs.ST-BROWSERsettings UI (crates/app/src/settings/diffs_browser.rs):unavailable(...)stubs under Browser Settings for Browser profiles (list persistent profiles, add blank profile up to 24, inline rename, set default + reset,preview.clearProfileclear cookies/cache and remove), Default browser viewport (Fill panel, Responsive, 17 Chrome DevTools presets, custom width × height inputs with bounds validation, rotate button, reset), Default browser zoom (17 zoom steps + reset), and Default browser appearance (System/Light/Dark+ reset), all with localizedcrate::i18n::t(cx, ...)/t_fmt(cx, ...)labels.PN-PREVIEWconsumption & i18n (crates/app/src/preview/{mod.rs, pane.rs, tests.rs}):Previews::report_profiles_if_needed(deduplicated per connection on server-browser readiness, grant changes, and Settings profile edits).crate::i18n::t(cx, ...).Previews::browser_defaults(cx),preview.openpayloads,AppState::reopen_closed_viewclosed-tab fallbacks,PreviewPane::toggle_device_toolbar, and deduplicatedpreview.reportProfilescalls, plus aSettingsViewBrowser page GPUI render test.apps/native/parity/LEDGER.md):PN-PREVIEW(partial | #249->done |) andST-BROWSER(partial | #99->done |) only, documenting Electron-only N/A items honestly.Verification
CARGO_INCREMENTAL=0 cargo clippy --manifest-path apps/native/Cargo.toml --workspace --all-targets -- -D warnings: pass (0 warnings)CARGO_INCREMENTAL=0 cargo test --manifest-path apps/native/Cargo.toml -p t3-core: 1,858 unit + 8 conformance passed, 0 failedCARGO_INCREMENTAL=0 cargo test --manifest-path apps/native/Cargo.toml -p t3-client -- --test-threads=4: 163 passed, 0 failedCARGO_INCREMENTAL=0 cargo test --manifest-path apps/native/Cargo.toml -p t3-native -- --test-threads=1(isolatedT3_NATIVE_HOME): 209 passed, 0 failedCARGO_INCREMENTAL=0 cargo test --manifest-path apps/native/Cargo.toml -p t3-native --features snapshot -- --test-threads=1 preview::tests diffs_browser settings::general::tests(isolatedT3_NATIVE_HOME): 19 passed, 0 failedCARGO_INCREMENTAL=0 cargo build --manifest-path apps/native/Cargo.toml -p t3-native: passvp fmt --check apps/native/parity/LEDGER.md: passnode apps/native/scripts/gen-theme.ts --check: passnode apps/native/conformance/generate.ts --check: passnode --test apps/native/parity/sync.test.ts: 47 passed, 0 failedGenerated by Antigravity (
h1-browser-preview).