Repository navigation
feat(native): add SQLite table/row viewer and composer file-mention drop target (PN-FILES) - #458
Merged
Merged
Conversation
… localize loading label
This was referenced Nov 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the final two remaining parity gaps on
PN-FILESand flipsPN-FILESfrompartialtodoneinapps/native/parity/LEDGER.md.Part of #249
What changed
Read-only SQLite table & paged row viewer (
crates/core/src/files/sqlite.rs,crates/app/src/files/{sqlite.rs, binary.rs, preview.rs})t3_core::files::sqlitemodule holding protocol bounds (SQLITE_PAGE_SIZE = 50,SQLITE_MAX_TABLES = 100,SQLITE_MAX_COLUMNS = 50,SQLITE_MAX_CELL_CHARS = 1024), clamped page math, SQL identifier quoting,PRAGMA table_xinfocolumn filtering (hidden != 1),NULL/INTEGER/REAL/TEXT/BLOBhex summary formatting, and bounded SQL projection builders.rusqlite = 0.32toapps/native/crates/app/Cargo.tomland implementedSqliteDatabaseHandlebacked by an RAII0600temp file removed on drop, opened withSQLITE_OPEN_READ_ONLY | SQLITE_OPEN_NO_MUTEXandPRAGMA query_only = ON; PRAGMA trusted_schema = OFF;on a background executor.sqlite_master(excludingsqlite_%internal tables and virtual tables), queriesGENERATED ALWAYS AS (...) VIRTUAL/STOREDcolumns viaPRAGMA table_xinfo, supportsWITHOUT ROWIDtables and quoted identifiers, and surfaces clean error messages for corrupt/encrypted databases and >100 tables.PK/GENhints), virtualized horizontally & vertically scrollable 50-row grid, Prev/Next pagination with localizedt/t_fmtstrings, read-only notice, and Database/Hex mode toggle.Composer drop target for
DraggedFileMention(crates/app/src/composer/view.rs).drag_over::<DraggedFileMention>(...)visual highlight and.on_drop::<DraggedFileMention>(...)on#composer-card, delegating each dragged path toinsert_mentionso single- and multi-file drops from the Files explorer matchAdd to chatinsertion while preserving existing draft text, whitespace boundaries, and cursor position, and respecting rewind/disabled/voice-frozen/question guards.Parity ledger (
apps/native/parity/LEDGER.md)PN-FILESfrompartial | #249todone |and documented both additions.Verification
CARGO_INCREMENTAL=0 cargo clippy --workspace --all-targets -- -D warnings: pass (0 warnings)CARGO_INCREMENTAL=0 cargo test -p t3-core: 1,860 unit + 8 conformance passed, 0 failedCARGO_INCREMENTAL=0 cargo test -p t3-client: 163 passed, 0 failedT3_NATIVE_HOME=<tmp> CARGO_INCREMENTAL=0 cargo test -p t3-native -- --test-threads=1: 213 passed, 0 failed (including new unit + GPUI tests for SQLite tables/paging/generated columns/corrupt errors/Hex toggle and composerDraggedFileMentiondrop handling)CARGO_INCREMENTAL=0 cargo build -p t3-native: passvp fmt --check apps/native/parity/LEDGER.md: passnode apps/native/scripts/gen-theme.ts --check: passnode apps/native/conformance/generate.ts --check: passnode --test apps/native/parity/sync.test.ts: 47 passed, 0 failedBuilt with Antigravity (Gemini).