Repository navigation
feat(linfa-linear): support sample weights in LinearRegression - #461
Open
divakantpandey wants to merge 1 commit into
Open
divakantpandey wants to merge 1 commit into
divakantpandey wants to merge 1 commit into
Conversation
Support Weighted Least Squares (WLS) when sample weights are attached to DatasetBase. Scale design matrix rows and targets by the square root of sample weights prior to solving least squares, validate non-negative weights, and add unit tests covering outlier filtering and uniform weight equivalence.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #328.
DatasetBasesupports sample weights via.with_weights(), butLinearRegression::fitpreviously ignored them and performed unweighted ordinary least squares.This PR adds Weighted Least Squares (WLS) support:
dataset.weights()is present, design matrix rows and targets are scaled bysqrt(w_i)prior to the least squares solve.LinearError::InvalidWeightsfor negative values andlinfa::Error::MismatchedShapesfor length mismatches.dataset.weights()isNone.