Repository navigation
Move promoted MIR out of mir::Body - #63580
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
commented
Aug 17, 2019
|
curious, why didn't the failing tests error before? They should have emitted the Can you adjust the test accordingly? |
8f96a77 to
580b2e2
Compare
commented
Aug 17, 2019
|
Awesome. This is ready now, right? If so, please adjust the PR message |
commented
Aug 17, 2019
|
I believe so. I'm just waiting for the tests to pass. |
commented
Aug 17, 2019
|
r=me once they do |
This comment has been minimized.
This comment has been minimized.
580b2e2 to
0278570
Compare
|
I ran |
This comment has been minimized.
This comment has been minimized.
0278570 to
da1f679
Compare
This comment has been minimized.
This comment has been minimized.
commented
Aug 17, 2019
|
Is that off by one swapping all the time? Maybe there's some ordering that is randomized via a hashmap iteration? |
da1f679 to
7369726
Compare
commented
Aug 18, 2019
I don't think so. I ran the test a bunch of times locally and it consistently failed. I think I just missed adding this change before committing. |
This comment has been minimized.
This comment has been minimized.
commented
Aug 26, 2019
|
@bors r+ |
commented
Aug 26, 2019
|
📌 Commit d6bf776 has been approved by |
commented
Aug 26, 2019
commented
Aug 26, 2019
|
☀️ Test successful - checks-azure |
|
Looks like this PR causes ICEs when running the Miri test suite with MIR optimizations. To reproduce, build Miri with a rustc including this PR, and run Stacktrace |
|
|
||
| //FIXME(oli-obk): having a `maybe_push()` method on `IndexVec` might be nice | ||
| if let Some(promoted) = promoter.promote_candidate(def_id, candidate, promotions.len()) { | ||
| promotions.push(promoted); |
There was a problem hiding this comment.
Pretty sure you can just use extend in such situations.
| promoter.promote_candidate(candidate); | ||
|
|
||
| //FIXME(oli-obk): having a `maybe_push()` method on `IndexVec` might be nice | ||
| if let Some(promoted) = promoter.promote_candidate(def_id, candidate, promotions.len()) { |
There was a problem hiding this comment.
Would be nice to pass the IndexVec key and not an usize here.
r? @oli-obk