Repository navigation
Stabilize extern "custom" - #158504
Stabilize extern "custom"#158504
extern "custom"#158504Conversation
|
r? tgross35 |
|
|
|
cc @tgross35 |
This comment has been minimized.
This comment has been minimized.
|
Do we deny this on wasm? Wasm requires the function signature to be known when defining or importing it. |
|
In that case, does the whole concept of a naked function even make sense there? That is, can it do something that a normal function whose body is an Practically inline assembly is unstable (and extremely incomplete) for wasm, so I'm not sure if/how it'll eventually fit in. But we can deny |
|
Naked asm can avoid touching the stack, maybe there are cases that is useful? Naked asm doesn't help for defining functions that use ref types or GC types as there isn't a way to express those using rust syntax, so those still need |
|
Allowing only assembly calls seems quite restrictive in terms of cross platform capabilities, as a special case, an |
|
This is a restriction on |
|
Just making this explicit: #158621 removes support for wasm and spirv targets. Neither have stable assembly, so practically this doesn't change anything, but the whole concept of |
|
Makes sense to me. Thanks @folkertdev for your work on this. @rfcbot fcp merge lang cc @Amanieu |
|
@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
364b5d7 to
652ab85
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
…, r=tgross35 Stabilize `extern "custom"` tracking issue: rust-lang#140829 reference PR: rust-lang/reference#2300 closes rust-lang#140829 ## Summary An `extern "custom" fn` is a function with a custom ABI that is unknown to rust. Often these are low-level functions that pass arguments in different registers than any standard calling convention. ```rust #[unsafe(naked)] pub unsafe extern "custom" fn __aeabi_uidivmod() { core::arch::naked_asm!( "push {{lr}}", "sub sp, sp, rust-lang#4", "mov r2, sp", "bl {trampoline}", "ldr r1, [sp]", "add sp, sp, rust-lang#4", "pop {{pc}}", trampoline = sym crate::arm::__udivmodsi4 ); } unsafe extern "custom" { fn __fentry__(); } ``` ## Design Because rust doesn't know what calling convention to use, an `extern "custom"` function can only be called via inline assembly or FFI. ``` error: functions with the "custom" ABI cannot be called --> <source>:5:5 | 5 | bar(); | ^^^^^ | note: an `extern "custom"` function can only be called using inline assembly ``` An `extern "custom"` function definition must be a naked function: ``` error: items with the "custom" ABI can only be declared externally or defined via naked functions --> <source>:10:1 | 10 | unsafe extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: convert this to an `#[unsafe(naked)]` function | 10 + #[unsafe(naked)] 11 | unsafe extern "custom" fn bar() { | ``` An `extern "custom"` function definition must be unsafe. The intent here is that a safety comment is written on how this function may be called. ``` error: functions with the "custom" ABI must be unsafe --> <source>:10:1 | 10 | extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^ | help: add the `unsafe` keyword to this definition | 10 | unsafe extern "custom" fn bar() { | ++++++ ``` In an `extern "custom"` block, functions cannot be marked as `safe`: ``` error: foreign functions with the "custom" ABI cannot be safe --> <source>:16:5 | 16 | safe fn foobar(); | ^^^^^^^^^^^^^^^^^ | help: remove the `safe` keyword from this definition | 16 - safe fn foobar(); 16 + fn foobar(); ``` An `extern "custom"` function cannot have any arguments or a return type: ``` error: invalid signature for `extern "custom"` function --> <source>:6:31 | 6 | unsafe extern "custom" fn foo(a: i32) -> i32 { | ^^^^^^ ^^^ | = note: functions with the "custom" ABI cannot have any parameters or return type help: remove the parameters and return type | 6 - unsafe extern "custom" fn foo(a: i32) -> i32 { 6 + unsafe extern "custom" fn foo() { | ``` ## Tests - [tests/ui/abi/custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/custom.rs) tests that the feature works as expected, e.g. that functions can be defined, symbols are defined, and extern blocks can be used. - [tests/ui/abi/bad-custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/bad-custom.rs) checks the restrictions: definitions must be unsafe and naked, attempting to call an `extern "custom"` function gives an error, etc. - ## History * rust-lang#140566 * rust-lang#140829 * rust-lang#140770 * rust-lang#159780 ## unresolved questions None
…, r=tgross35 Stabilize `extern "custom"` tracking issue: rust-lang#140829 reference PR: rust-lang/reference#2300 closes rust-lang#140829 ## Summary An `extern "custom" fn` is a function with a custom ABI that is unknown to rust. Often these are low-level functions that pass arguments in different registers than any standard calling convention. ```rust #[unsafe(naked)] pub unsafe extern "custom" fn __aeabi_uidivmod() { core::arch::naked_asm!( "push {{lr}}", "sub sp, sp, rust-lang#4", "mov r2, sp", "bl {trampoline}", "ldr r1, [sp]", "add sp, sp, rust-lang#4", "pop {{pc}}", trampoline = sym crate::arm::__udivmodsi4 ); } unsafe extern "custom" { fn __fentry__(); } ``` ## Design Because rust doesn't know what calling convention to use, an `extern "custom"` function can only be called via inline assembly or FFI. ``` error: functions with the "custom" ABI cannot be called --> <source>:5:5 | 5 | bar(); | ^^^^^ | note: an `extern "custom"` function can only be called using inline assembly ``` An `extern "custom"` function definition must be a naked function: ``` error: items with the "custom" ABI can only be declared externally or defined via naked functions --> <source>:10:1 | 10 | unsafe extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: convert this to an `#[unsafe(naked)]` function | 10 + #[unsafe(naked)] 11 | unsafe extern "custom" fn bar() { | ``` An `extern "custom"` function definition must be unsafe. The intent here is that a safety comment is written on how this function may be called. ``` error: functions with the "custom" ABI must be unsafe --> <source>:10:1 | 10 | extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^ | help: add the `unsafe` keyword to this definition | 10 | unsafe extern "custom" fn bar() { | ++++++ ``` In an `extern "custom"` block, functions cannot be marked as `safe`: ``` error: foreign functions with the "custom" ABI cannot be safe --> <source>:16:5 | 16 | safe fn foobar(); | ^^^^^^^^^^^^^^^^^ | help: remove the `safe` keyword from this definition | 16 - safe fn foobar(); 16 + fn foobar(); ``` An `extern "custom"` function cannot have any arguments or a return type: ``` error: invalid signature for `extern "custom"` function --> <source>:6:31 | 6 | unsafe extern "custom" fn foo(a: i32) -> i32 { | ^^^^^^ ^^^ | = note: functions with the "custom" ABI cannot have any parameters or return type help: remove the parameters and return type | 6 - unsafe extern "custom" fn foo(a: i32) -> i32 { 6 + unsafe extern "custom" fn foo() { | ``` ## Tests - [tests/ui/abi/custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/custom.rs) tests that the feature works as expected, e.g. that functions can be defined, symbols are defined, and extern blocks can be used. - [tests/ui/abi/bad-custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/bad-custom.rs) checks the restrictions: definitions must be unsafe and naked, attempting to call an `extern "custom"` function gives an error, etc. - ## History * rust-lang#140566 * rust-lang#140829 * rust-lang#140770 * rust-lang#159780 ## unresolved questions None
…uwer Rollup of 5 pull requests Successful merges: - #161111 (Take bors try-perf branch into account in verify-channel.sh) - #158504 (Stabilize `extern "custom"`) - #161030 (mailmap: fix nia's gazillion emails) - #161105 (rustdoc: Small `doc_cfg` messages improvements) - #161123 (bootstrap: Clean up some inconsistent imports and paths)
Rollup merge of #158504 - folkertdev:stabilize-extern-custom, r=tgross35 Stabilize `extern "custom"` tracking issue: #140829 reference PR: rust-lang/reference#2300 closes #140829 ## Summary An `extern "custom" fn` is a function with a custom ABI that is unknown to rust. Often these are low-level functions that pass arguments in different registers than any standard calling convention. ```rust #[unsafe(naked)] pub unsafe extern "custom" fn __aeabi_uidivmod() { core::arch::naked_asm!( "push {{lr}}", "sub sp, sp, #4", "mov r2, sp", "bl {trampoline}", "ldr r1, [sp]", "add sp, sp, #4", "pop {{pc}}", trampoline = sym crate::arm::__udivmodsi4 ); } unsafe extern "custom" { fn __fentry__(); } ``` ## Design Because rust doesn't know what calling convention to use, an `extern "custom"` function can only be called via inline assembly or FFI. ``` error: functions with the "custom" ABI cannot be called --> <source>:5:5 | 5 | bar(); | ^^^^^ | note: an `extern "custom"` function can only be called using inline assembly ``` An `extern "custom"` function definition must be a naked function: ``` error: items with the "custom" ABI can only be declared externally or defined via naked functions --> <source>:10:1 | 10 | unsafe extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: convert this to an `#[unsafe(naked)]` function | 10 + #[unsafe(naked)] 11 | unsafe extern "custom" fn bar() { | ``` An `extern "custom"` function definition must be unsafe. The intent here is that a safety comment is written on how this function may be called. ``` error: functions with the "custom" ABI must be unsafe --> <source>:10:1 | 10 | extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^ | help: add the `unsafe` keyword to this definition | 10 | unsafe extern "custom" fn bar() { | ++++++ ``` In an `extern "custom"` block, functions cannot be marked as `safe`: ``` error: foreign functions with the "custom" ABI cannot be safe --> <source>:16:5 | 16 | safe fn foobar(); | ^^^^^^^^^^^^^^^^^ | help: remove the `safe` keyword from this definition | 16 - safe fn foobar(); 16 + fn foobar(); ``` An `extern "custom"` function cannot have any arguments or a return type: ``` error: invalid signature for `extern "custom"` function --> <source>:6:31 | 6 | unsafe extern "custom" fn foo(a: i32) -> i32 { | ^^^^^^ ^^^ | = note: functions with the "custom" ABI cannot have any parameters or return type help: remove the parameters and return type | 6 - unsafe extern "custom" fn foo(a: i32) -> i32 { 6 + unsafe extern "custom" fn foo() { | ``` ## Tests - [tests/ui/abi/custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/custom.rs) tests that the feature works as expected, e.g. that functions can be defined, symbols are defined, and extern blocks can be used. - [tests/ui/abi/bad-custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/bad-custom.rs) checks the restrictions: definitions must be unsafe and naked, attempting to call an `extern "custom"` function gives an error, etc. - ## History * #140566 * #140829 * #140770 * #159780 ## unresolved questions None
Rollup merge of #158504 - folkertdev:stabilize-extern-custom, r=tgross35 Stabilize `extern "custom"` tracking issue: #140829 reference PR: rust-lang/reference#2300 closes #140829 ## Summary An `extern "custom" fn` is a function with a custom ABI that is unknown to rust. Often these are low-level functions that pass arguments in different registers than any standard calling convention. ```rust #[unsafe(naked)] pub unsafe extern "custom" fn __aeabi_uidivmod() { core::arch::naked_asm!( "push {{lr}}", "sub sp, sp, #4", "mov r2, sp", "bl {trampoline}", "ldr r1, [sp]", "add sp, sp, #4", "pop {{pc}}", trampoline = sym crate::arm::__udivmodsi4 ); } unsafe extern "custom" { fn __fentry__(); } ``` ## Design Because rust doesn't know what calling convention to use, an `extern "custom"` function can only be called via inline assembly or FFI. ``` error: functions with the "custom" ABI cannot be called --> <source>:5:5 | 5 | bar(); | ^^^^^ | note: an `extern "custom"` function can only be called using inline assembly ``` An `extern "custom"` function definition must be a naked function: ``` error: items with the "custom" ABI can only be declared externally or defined via naked functions --> <source>:10:1 | 10 | unsafe extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: convert this to an `#[unsafe(naked)]` function | 10 + #[unsafe(naked)] 11 | unsafe extern "custom" fn bar() { | ``` An `extern "custom"` function definition must be unsafe. The intent here is that a safety comment is written on how this function may be called. ``` error: functions with the "custom" ABI must be unsafe --> <source>:10:1 | 10 | extern "custom" fn bar() { | ^^^^^^^^^^^^^^^^^^^^^^^^ | help: add the `unsafe` keyword to this definition | 10 | unsafe extern "custom" fn bar() { | ++++++ ``` In an `extern "custom"` block, functions cannot be marked as `safe`: ``` error: foreign functions with the "custom" ABI cannot be safe --> <source>:16:5 | 16 | safe fn foobar(); | ^^^^^^^^^^^^^^^^^ | help: remove the `safe` keyword from this definition | 16 - safe fn foobar(); 16 + fn foobar(); ``` An `extern "custom"` function cannot have any arguments or a return type: ``` error: invalid signature for `extern "custom"` function --> <source>:6:31 | 6 | unsafe extern "custom" fn foo(a: i32) -> i32 { | ^^^^^^ ^^^ | = note: functions with the "custom" ABI cannot have any parameters or return type help: remove the parameters and return type | 6 - unsafe extern "custom" fn foo(a: i32) -> i32 { 6 + unsafe extern "custom" fn foo() { | ``` ## Tests - [tests/ui/abi/custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/custom.rs) tests that the feature works as expected, e.g. that functions can be defined, symbols are defined, and extern blocks can be used. - [tests/ui/abi/bad-custom.rs](https://github.com/rust-lang/rust/blob/main/tests/ui/abi/bad-custom.rs) checks the restrictions: definitions must be unsafe and naked, attempting to call an `extern "custom"` function gives an error, etc. - ## History * #140566 * #140829 * #140770 * #159780 ## unresolved questions None
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#161111 (Take bors try-perf branch into account in verify-channel.sh) - rust-lang/rust#158504 (Stabilize `extern "custom"`) - rust-lang/rust#161030 (mailmap: fix nia's gazillion emails) - rust-lang/rust#161105 (rustdoc: Small `doc_cfg` messages improvements) - rust-lang/rust#161123 (bootstrap: Clean up some inconsistent imports and paths)
Pkgsrc changes: * Version & checksum changes. * Adapt patches to match. Upstream changes: Version 1.100.0 (2026-11-12) ========================== Language -------- - [Stabilize never type] (rust-lang/rust#155499) - [Lint against repeated `#[repr(..)]` attributes] (rust-lang/rust#157036) - [Stabilize `extern "custom"`] (rust-lang/rust#158504) - [Extend `dropping_references`, `dropping_copy_types` and `undropped_manually_drops` lints to `drop_in_place`] (rust-lang/rust#160229) - [`unfulfilled_lint_expectations` no longer fires on `#[expect(dead_code)]` inside code that is covered by a dead parent's diagnostic] (rust-lang/rust#161005) - [Turn the error for `repr(align)` fields in a `repr(packed)` type into a deny-by-default lint `aligned_fields_in_packed`] (rust-lang/rust#162160) - [volatile: allow accesses to non-AM memory to trap] (rust-lang/rust#160564) Compiler -------- - [Stabilize `-Cprofile-sample-use`] (rust-lang/rust#155942) - [Enable next solver by default in orphanck] (rust-lang/rust#160668) Platform Support ---------------- - [`i686-pc-windows-gnu` is now a tier 2 without host tools target] (rust-lang/rust#161681) - [Promote `wasm32-wasip3` to Tier 2] (rust-lang/rust#161940) - [Add new Tier 3 target `powerpc64-sony-ps3`] (rust-lang/rust#162072) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. [platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html Libraries --------- - [Stabilize custom allocators] (rust-lang/rust#156882) - [Map `ENOTSUP` to `ErrorKind::Unsupported`] (rust-lang/rust#158580) - [Fix soundness issues in `std::sys::pal::sgx::waitqueue::unsafe_list`] (rust-lang/rust#161334) Stabilized APIs --------------- - [`impl PartialEq<Cow<'_, [U]>> for Vec<T, A>`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-Vec%3CT,+A%3E) - [`impl PartialEq<Cow<'_, [U]>> for &[T]`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-%26%5BT%5D) - [`impl PartialEq<Cow<'_, [U]>> for &mut [T]`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-%26mut+%5BT%5D) - [`std::alloc::Allocator`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html) - [`std::alloc::Global`] (https://doc.rust-lang.org/stable/std/alloc/struct.Global.html) - [`std::alloc::System`] (https://doc.rust-lang.org/stable/std/alloc/struct.System.html) - [`impl Allocator for Global`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Global) - [`impl Allocator for System`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-System) - [`impl<A: Allocator> Allocator for &A`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-%26A) - [`impl<T: Allocator, A: Allocator> Allocator for Box<T, A>`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Box%3CT,+A%3E) - [`impl<A: Allocator> Allocator for &mut A`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-%26mut+A) - [`impl<T: Allocator, A: Allocator> Allocator for Arc<T, A>`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Arc%3CT,+A%3E) - [`impl<T: Allocator, A: Allocator> Allocator for Rc<T, A>`] (https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Rc%3CT,+A%3E) - [`Box::new_in`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.new_in) - [`Box::from_raw_in`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.from_raw_in) - [`Box::from_non_null_in`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.from_non_null_in) - [`Box::into_raw_with_allocator`] (https://doc.rust-lang.org/std/std/boxed/struct.Box.html#method.into_raw_with_allocator) - [`Box::into_non_null_with_allocator`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_non_null_with_allocator) - [`Box::allocator`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.allocator) - [`Vec::new_in`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.new_in) - [`Vec::with_capacity_in`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.with_capacity_in) - [`Vec::from_raw_parts_in`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_raw_parts_in) - [`Vec::from_parts_in`] (https://doc.rust-lang.org/stable/stable/vec/struct.Vec.html#method.from_parts_in) - [`Vec::into_raw_parts_with_allocator`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_raw_parts_with_allocator) - [`Vec::into_parts_with_allocator`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_parts_with_allocator) - [`Vec::allocator`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.allocator) - [`Child::main_thread_handle`] (https://doc.rust-lang.org/stable/std/os/windows/process/trait.ChildExt.html#tymethod.main_thread_handle) - [`impl Default for std::sync::Once`] (https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-Default-for-Once) - [`bool::toggle`] (https://doc.rust-lang.org/stable/std/primitive.bool.html#method.toggle) - [`Box::take`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.take) - [`Box::map`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.map) - [`Rc::map`] (https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.map) - [`Arc::map`] (https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.map) - [`impl AsRef<T> for !`] (https://doc.rust-lang.org/stable/std/primitive.never.html#impl-AsRef<T>-for-!) - [`impl AsMut<T> for !`] (https://doc.rust-lang.org/stable/std/primitive.never.html#impl-AsMut<T>-for-!) - [`core::mem::DropGuard`] (https://doc.rust-lang.org/stable/core/mem/struct.DropGuard.html) - [`core::mem::conjure_zst`] (https://doc.rust-lang.org/stable/core/mem/fn.conjure_zst.html) - [`UnsafeCell::replace`] (https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.replace) - [`UnsafeCell::as_ref_unchecked`] (https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.as_ref_unchecked) - [`UnsafeCell::as_mut_unchecked`] (https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.as_mut_unchecked) - [`str::trim_prefix`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.trim_prefix) - [`str::trim_suffix`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.trim_suffix) - [`[T]::trim_prefix`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.trim_prefix) - [`[T]::trim_suffix`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.trim_suffix) - [`Path::trim_prefix`] (https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.trim_prefix) - [`Vec::from_fn`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_fn) - [`os::windows::process::CommandExt::show_window`] (https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html#tymethod.show_window) Cargo ----- - Introduced Cargo's own linting system: some Cargo warnings are now emitted as lints that users can control in the `[lints.cargo]` table. This includes a new built-in unused dependency check via the `cargo::unused_dependencies` lint. [docs](https://doc.rust-lang.org/stable/cargo/reference/lints.html) [#17298](rust-lang/cargo#17298) - Introduced minimum publish age configurations, also known as dependency cooldowns. When the relevant config is set, the resolver ignores versions published more recently than that, unless they are already in `Cargo.lock`. ([RFC 3923] (https://rust-lang.github.io/rfcs/3923-cargo-min-publish-age.html)) [docs] (https://doc.rust-lang.org/stable/cargo/reference/resolver.html#publish-age) [#17335] (rust-lang/cargo#17335) - cargo-install: now uses the existing lockfile in the `.crate` tarball by default. `--locked` in cargo install becomes a no-op. [#17388](rust-lang/cargo#17388) - Cargo now uses a new directory layout for intermediate build artifacts. Tools that inspect the build directory may need to use [Cargoâs JSON messages] (https://doc.rust-lang.org/stable/cargo/reference/external-tools.html#json-messages) to locate build artifacts instead of relying on the build directory layout. The layout is not a stable interface and is subject to change. ([build cache doc] (https://doc.rust-lang.org/stable/cargo/reference/build-cache.html)) [#17354](rust-lang/cargo#17354) Rustdoc ----- - [Add new `invalid_markdown_table` rustdoc lint] (rust-lang/rust#159583) Compatibility Notes ------------------- - [Closures now more precisely capture variables used in `if let`. This may cause new errors] (rust-lang/rust#154210) - [Check dyn-compatibility of trait objects in more places] (rust-lang/rust#154992) - [`Infallible` is now a type alias to `!`] (rust-lang/rust#155499) - [The never type fallback was changed to `!` on all editions] (rust-lang/rust#155499) - [`box` patterns are no longer syntactically allowed] (rust-lang/rust#156749) - [Report Query Cycle errors in more cases when computing the layout of enums with explicit discriminants] (rust-lang/rust#157562) - [Always escape grapheme extenders in `str::escape_debug`] (rust-lang/rust#158303) - [Make let-else respect `macro_rules` `expr` metavariable grouping] (rust-lang/rust#158515) - [`Iterator::{min,max}(_by_key)` changed which `Ord` methods they use.] (rust-lang/rust#160203) This cannot change behaviour (other than being potentially faster) for types correctly following the [`Ord` rules] (https://doc.rust-lang.org/std/cmp/trait.Ord.html), but may impact types with inconsistent trait implementations. - [Emit an error when trying to enable SSE/AVX on an x86 (32bit or 64bit) softfloat target] (rust-lang/rust#160302) - [Require windowed (and exception) for Xtensa ABI] (rust-lang/rust#160643) - [windows-gnullvm: always link libunwind statically] (rust-lang/rust#160712) - [From version 1.94 up to 1.100 a number of ARMv7-A hardfloat targets required the `VFPv3-D32` FPU as a minimum, as they erroneously had the `d32` feature in their baseline list of features. Breakage introduced as a result of correcting this can be fixed by passing `-Ctarget-feature=+d32` to Rust.] (rust-lang/rust#160911) - [Change "Rust" ABI on x86 to use SSE registers if they are always-available for the current target] (rust-lang/rust#161583) - [Make the `ambiguous_glob_imported_traits` lint fire in slightly more cases] (rust-lang/rust#161805) - [Make `+fix-cortex-a53-835769` a default feature for `aarch64-unknown-fuchsia`] (rust-lang/rust#161886) - [Some impls on `Box` have been generalised to arbitrary allocators, which may cause new type inference errors] (rust-lang/rust#161946) - [The standard library now uses Unicode version 18.0.0] (https://doc.rust-lang.org/stable/std/primitive.char.html#associatedconstant.UNICODE_VERSION) - [WASI SDK version was bumped from 33 to 34] (rust-lang/rust#163809) - [On ARM targets, `-Ctarget-feature`/`-Ctarget-cpu` values that would alter the ABI are rejected as hard errors now.] (rust-lang/rust#161280) Other ----- - [Test harness now allows passing `--test-threads` and `--color` multiple times, with later arguments overriding earlier ones] (rust-lang/rust#161312)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rust](https://rust-lang.org/) ([source](https://github.com/rust-lang/rust), [changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md)) | tools | minor | `1.99.1` → `1.100.0` | | [rust](https://hub.docker.com/_/rust) ([source](https://github.com/rust-lang/docker-rust)) | stage | minor | `1.99-slim-trixie` → `1.100-slim-trixie` | | [rust](https://hub.docker.com/_/rust) ([source](https://github.com/rust-lang/docker-rust)) | final | minor | `1.99-slim-trixie` → `1.100-slim-trixie` | --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.100.0`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-11000-2026-11-12) [Compare Source](rust-lang/rust@1.99.1...1.100.0) \========================== <a id="1.100.0-Language"></a> ## Language - [Stabilize never type](rust-lang/rust#155499) - [Lint against repeated `#[repr(..)]` attributes](rust-lang/rust#157036) - [Stabilize `extern "custom"`](rust-lang/rust#158504) - [Extend `dropping_references`, `dropping_copy_types` and `undropped_manually_drops` lints to `drop_in_place`](rust-lang/rust#160229) - [`unfulfilled_lint_expectations` no longer fires on `#[expect(dead_code)]` inside code that is covered by a dead parent's diagnostic](rust-lang/rust#161005) - [Turn the error for `repr(align)` fields in a `repr(packed)` type into a deny-by-default lint `aligned_fields_in_packed`](rust-lang/rust#162160) - [volatile: allow accesses to non-AM memory to trap](rust-lang/rust#160564) <a id="1.100.0-Compiler"></a> ## Compiler - [Stabilize `-Cprofile-sample-use`](rust-lang/rust#155942) - [Enable next solver by default in orphanck](rust-lang/rust#160668) <a id="1.100.0-Platform-Support"></a> ## Platform Support - [`i686-pc-windows-gnu` is now a tier 2 without host tools target](rust-lang/rust#161681) - [Promote `wasm32-wasip3` to Tier 2](rust-lang/rust#161940) - [Add new Tier 3 target `powerpc64-sony-ps3`](rust-lang/rust#162072) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. [platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html <a id="1.100.0-Libraries"></a> ## Libraries - [Stabilize custom allocators](rust-lang/rust#156882) - [Map `ENOTSUP` to `ErrorKind::Unsupported`](rust-lang/rust#158580) - [Fix soundness issues in `std::sys::pal::sgx::waitqueue::unsafe_list`](rust-lang/rust#161334) <a id="1.100.0-Stabilized-APIs"></a> ## Stabilized APIs - [`impl PartialEq<Cow<'_, [U]>> for Vec<T, A>`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-Vec%3CT,+A%3E) - [`impl PartialEq<Cow<'_, [U]>> for &[T]`](https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-%26%5BT%5D) - [`impl PartialEq<Cow<'_, [U]>> for &mut [T]`](https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-PartialEq%3CCow%3C'_,+%5BU%5D%3E%3E-for-%26mut+%5BT%5D) - [`std::alloc::Allocator`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html) - [`std::alloc::Global`](https://doc.rust-lang.org/stable/std/alloc/struct.Global.html) - [`std::alloc::System`](https://doc.rust-lang.org/stable/std/alloc/struct.System.html) - [`impl Allocator for Global`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Global) - [`impl Allocator for System`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-System) - [`impl<A: Allocator> Allocator for &A`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-%26A) - [`impl<T: Allocator, A: Allocator> Allocator for Box<T, A>`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Box%3CT,+A%3E) - [`impl<A: Allocator> Allocator for &mut A`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-%26mut+A) - [`impl<T: Allocator, A: Allocator> Allocator for Arc<T, A>`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Arc%3CT,+A%3E) - [`impl<T: Allocator, A: Allocator> Allocator for Rc<T, A>`](https://doc.rust-lang.org/stable/std/alloc/trait.Allocator.html#impl-Allocator-for-Rc%3CT,+A%3E) - [`Box::new_in`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.new_in) - [`Box::from_raw_in`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.from_raw_in) - [`Box::from_non_null_in`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.from_non_null_in) - [`Box::into_raw_with_allocator`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_raw_with_allocator) - [`Box::into_non_null_with_allocator`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_non_null_with_allocator) - [`Box::allocator`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.allocator) - [`Vec::new_in`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.new_in) - [`Vec::with_capacity_in`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.with_capacity_in) - [`Vec::from_raw_parts_in`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_raw_parts_in) - [`Vec::from_parts_in`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_parts_in) - [`Vec::into_raw_parts_with_allocator`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_raw_parts_with_allocator) - [`Vec::into_parts_with_allocator`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_parts_with_allocator) - [`Vec::allocator`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.allocator) - [`Child::main_thread_handle`](https://doc.rust-lang.org/stable/std/os/windows/process/trait.ChildExt.html#tymethod.main_thread_handle) - [`impl Default for std::sync::Once`](https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-Default-for-Once) - [`bool::toggle`](https://doc.rust-lang.org/stable/std/primitive.bool.html#method.toggle) - [`Box::take`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.take) - [`Box::map`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.map) - [`Rc::map`](https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.map) - [`Arc::map`](https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.map) - [`impl AsRef<T> for !`](https://doc.rust-lang.org/stable/std/primitive.never.html#impl-AsRef<T>-for-!) - [`impl AsMut<T> for !`](https://doc.rust-lang.org/stable/std/primitive.never.html#impl-AsMut<T>-for-!) - [`core::mem::DropGuard`](https://doc.rust-lang.org/stable/core/mem/struct.DropGuard.html) - [`core::mem::conjure_zst`](https://doc.rust-lang.org/stable/core/mem/fn.conjure_zst.html) - [`UnsafeCell::replace`](https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.replace) - [`UnsafeCell::as_ref_unchecked`](https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.as_ref_unchecked) - [`UnsafeCell::as_mut_unchecked`](https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.as_mut_unchecked) - [`str::trim_prefix`](https://doc.rust-lang.org/stable/std/primitive.str.html#method.trim_prefix) - [`str::trim_suffix`](https://doc.rust-lang.org/stable/std/primitive.str.html#method.trim_suffix) - [`[T]::trim_prefix`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.trim_prefix) - [`[T]::trim_suffix`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.trim_suffix) - [`Path::trim_prefix`](https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.trim_prefix) - [`Vec::from_fn`](https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_fn) - [`os::windows::process::CommandExt::show_window`](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html#tymethod.show_window) <a id="1.100.0-Cargo"></a> ## Cargo - Introduced Cargo's own linting system: some Cargo warnings are now emitted as lints that users can control in the `[lints.cargo]` table. This includes a new built-in unused dependency check via the `cargo::unused_dependencies` lint. [docs](https://doc.rust-lang.org/stable/cargo/reference/lints.html) [#​17298](rust-lang/cargo#17298) - Introduced minimum publish age configurations, also known as dependency cooldowns. When the relevant config is set, the resolver ignores versions published more recently than that, unless they are already in `Cargo.lock`. ([RFC 3923](https://rust-lang.github.io/rfcs/3923-cargo-min-publish-age.html)) [docs](https://doc.rust-lang.org/stable/cargo/reference/resolver.html#publish-age) [#​17335](rust-lang/cargo#17335) - cargo-install: now uses the existing lockfile in the `.crate` tarball by default. `--locked` in cargo install becomes a no-op. [#​17388](rust-lang/cargo#17388) - Cargo now uses a new directory layout for intermediate build artifacts. Tools that inspect the build directory may need to use [Cargo’s JSON messages](https://doc.rust-lang.org/stable/cargo/reference/external-tools.html#json-messages) to locate build artifacts instead of relying on the build directory layout. The layout is not a stable interface and is subject to change. ([build cache doc](https://doc.rust-lang.org/stable/cargo/reference/build-cache.html)) [#​17354](rust-lang/cargo#17354) ## Rustdoc - [Add new `invalid_markdown_table` rustdoc lint](rust-lang/rust#159583) <a id="1.100.0-Compatibility-Notes"></a> ## Compatibility Notes - [Closures now more precisely capture variables used in `if let`. This may cause new errors](rust-lang/rust#154210) - [Check dyn-compatibility of trait objects in more places](rust-lang/rust#154992) - [`Infallible` is now a type alias to `!`](rust-lang/rust#155499) - [The never type fallback was changed to `!` on all editions](rust-lang/rust#155499) - [`box` patterns are no longer syntactically allowed](rust-lang/rust#156749) - [Report Query Cycle errors in more cases when computing the layout of enums with explicit discriminants](rust-lang/rust#157562) - [Always escape grapheme extenders in `str::escape_debug`](rust-lang/rust#158303) - [Make let-else respect `macro_rules` `expr` metavariable grouping](rust-lang/rust#158515) - [`Iterator::{min,max}(_by_key)` changed which `Ord` methods they use.](rust-lang/rust#160203) This cannot change behaviour (other than being potentially faster) for types correctly following the [`Ord` rules](https://doc.rust-lang.org/std/cmp/trait.Ord.html), but may impact types with inconsistent trait implementations. - [Emit an error when trying to enable SSE/AVX on an x86 (32bit or 64bit) softfloat target](rust-lang/rust#160302) - [Require windowed (and exception) for Xtensa ABI](rust-lang/rust#160643) - [windows-gnullvm: always link libunwind statically](rust-lang/rust#160712) - [From version 1.94 up to 1.100 a number of ARMv7-A hardfloat targets required the `VFPv3-D32` FPU as a minimum, as they erroneously had the `d32` feature in their baseline list of features. Breakage introduced as a result of correcting this can be fixed by passing `-Ctarget-feature=+d32` to Rust.](rust-lang/rust#160911) - [Change "Rust" ABI on x86 to use SSE registers if they are always-available for the current target](rust-lang/rust#161583) - [Make the `ambiguous_glob_imported_traits` lint fire in slightly more cases](rust-lang/rust#161805) - [Make `+fix-cortex-a53-835769` a default feature for `aarch64-unknown-fuchsia`](rust-lang/rust#161886) - [Some impls on `Box` have been generalised to arbitrary allocators, which may cause new type inference errors](rust-lang/rust#161946) - [The standard library now uses Unicode version 18.0.0](https://doc.rust-lang.org/stable/std/primitive.char.html#associatedconstant.UNICODE_VERSION) - [WASI SDK version was bumped from 33 to 34](rust-lang/rust#163809) - [On ARM targets, `-Ctarget-feature`/`-Ctarget-cpu` values that would alter the ABI are rejected as hard errors now.](rust-lang/rust#161280) <a id="1.100.0-Internal-Changes"></a> ## Other - [Test harness now allows passing `--test-threads` and `--color` multiple times, with later arguments overriding earlier ones](rust-lang/rust#161312) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMjcuNCIsInVwZGF0ZWRJblZlciI6IjQ0LjIyNy40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/2356 Reviewed-by: Thomas de Zeeuw <thomas@futo.org>
View all comments
tracking issue: #140829
reference PR: rust-lang/reference#2300
closes #140829
Summary
An
extern "custom" fnis a function with a custom ABI that is unknown to rust. Often these are low-level functions that pass arguments in different registers than any standard calling convention.Design
Because rust doesn't know what calling convention to use, an
extern "custom"function can only be called via inline assembly or FFI.An
extern "custom"function definition must be a naked function:An
extern "custom"function definition must be unsafe. The intent here is that a safety comment is written on how this function may be called.In an
extern "custom"block, functions cannot be marked assafe:An
extern "custom"function cannot have any arguments or a return type:Tests
extern "custom"function gives an error, etc.History
extern "unspecified"for naked functions with arbitrary ABI #140566abi_custom#140829extern "custom"functions #140770extern "custom"function pointers #159780unresolved questions
None