You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Extract libcore benchmarks to a separate crate #39484
@phungleson yeah that should do the trick! I think that you can avoid a whole new directory even, but could have something like src/libcore/bench/*.rs and then that could get pulled in the Cargo.toml
@est31 in general compiling libcore with --test literally is a huge PITA because there's so many intermixed types. The "foreign" libcore (one linked by libtest) duplicates the local libcore (the one being compiled with --test) and it's very difficult to keep the types straight, especially for standard traits.
It ended up being easier to do everything out of the library
Activity
alexcrichton commentedon Feb 3, 2017
@phungleson yeah that should do the trick! I think that you can avoid a whole new directory even, but could have something like
src/libcore/bench/*.rsand then that could get pulled in theCargo.tomlRollup merge of rust-lang#39501 - phungleson:libcorebench, r=alexcric…
est31 commentedon Feb 5, 2017
I've recently been wondering what the reason behind that was. Any ideas? Any links to previous discussion?
Rollup merge of rust-lang#39501 - phungleson:libcorebench, r=alexcric…
Rollup merge of rust-lang#39501 - phungleson:libcorebench, r=alexcric…
alexcrichton commentedon Feb 5, 2017
@est31 in general compiling libcore with --test literally is a huge PITA because there's so many intermixed types. The "foreign" libcore (one linked by libtest) duplicates the local libcore (the one being compiled with --test) and it's very difficult to keep the types straight, especially for standard traits.
It ended up being easier to do everything out of the library
est31 commentedon Feb 5, 2017
@alexcrichton thanks!