Skip to content

E0004 bonus update: spans can't cross nodes #35529

Closed

Description

@sophiajt

From #35485

After talking with @arielb1 (and seeing @nrc's comments) - let's actually change the span to be one we can do safely:

From:

match x {
^^^^^^^ pattern `HastaLaVistaBaby` not covered

To:

match x {
      ^ pattern `HastaLaVistaBaby` not covered

CC: @KiChjang

Activity

  1. KiChjang commented on Aug 8, 2016

    @KiChjang
    Contributor

    Okay, this should be a simple fix, I'm taking it.

  2. arielb1 commented on Aug 8, 2016

    @arielb1
    Contributor

    I have a mega-pr #35308 that includes it.

  3. arielb1 commented on Aug 8, 2016

    @arielb1
    Contributor

    Still, I find spanning the scrutinee is a bit odd. But spanning the whole match isn't so pretty, so...

  4. KiChjang commented on Aug 8, 2016

    @KiChjang
    Contributor

    Commented on your PR.

  5. added a commit that references this issue on Aug 10, 2016
    ecbb3e3
  6. added 2 commits that reference this issue on Aug 10, 2016
    fc8e8b3
    d0922f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions