Skip to content

E0046 needs to be updated to new format #35209

Closed

Description

@sophiajt

From: src/test/compile-fail/E0046.rs

Error E0046 needs a span_label, updating it from:

error[E0046]: not all trait items implemented, missing: `foo`
  --> src/test/compile-fail/E0046.rs:17:1
   |
17 | impl Foo for Bar {} //~ ERROR E0046
   | ^^^^^^^^^^^^^^^^^^^

To:

error[E0046]: not all trait items implemented, missing: `foo`
  --> src/test/compile-fail/E0046.rs:17:1
   |
17 | impl Foo for Bar {} //~ ERROR E0046
   | ^^^^^^^^^^^^^^^^^^^ missing `foo` in implementation

Activity

  1. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    A-diagnosticsArea: Messages for errors, warnings, and lints
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Aug 2, 2016
  2. added 3 commits that reference this issue on Aug 7, 2016
  3. KiChjang commented on Aug 8, 2016

    @KiChjang
    Contributor

    Should be fixed by #35355.

  4. kali commented on Sep 16, 2016

    @kali
    Contributor

    Not sure if this is the right place, but it would be great if the error message was giving the whole prototype of the missing methods, ready to be cut-and-pasted (scalac does it).

  5. sophiajt commented on Sep 16, 2016

    @sophiajt
    ContributorAuthor

    @kali - can you file a new issue with your suggestion and cc me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions