Skip to content

E0034 needs to be updated to new format #35205

Closed

Description

@sophiajt

From: src/test/compile-fail/E0034.rs

The E0034 error message needs a span_label, changing it from:

error[E0034]: multiple applicable items in scope
  --> src/test/compile-fail/E0034.rs:25:5
   |
25 |     Test::foo() //~ ERROR E0034
   |     ^^^^^^^^^
   |
note: candidate #1 is defined in an impl of the trait `Trait1` for the type `Test`
  --> src/test/compile-fail/E0034.rs:21:24
   |
21 | impl Trait1 for Test { fn foo() {} }
   |                        ^^^^^^^^^^^
note: candidate #2 is defined in an impl of the trait `Trait2` for the type `Test`
  --> src/test/compile-fail/E0034.rs:22:24
   |
22 | impl Trait2 for Test { fn foo() {} }
   |                        ^^^^^^^^^^^

to:

error[E0034]: multiple applicable items in scope
  --> src/test/compile-fail/E0034.rs:25:5
   |
25 |     Test::foo() //~ ERROR E0034
   |     ^^^^^^^^^ multiple `foo` found
   |
note: candidate #1 is defined in an impl of the trait `Trait1` for the type `Test`
  --> src/test/compile-fail/E0034.rs:21:24
   |
21 | impl Trait1 for Test { fn foo() {} }
   |                        ^^^^^^^^^^^
note: candidate #2 is defined in an impl of the trait `Trait2` for the type `Test`
  --> src/test/compile-fail/E0034.rs:22:24
   |
22 | impl Trait2 for Test { fn foo() {} }
   |                        ^^^^^^^^^^^

Bonus: there may be additional fixes we can do to improve E0034 as well. We could explore underlining the candidates as secondary notes rather than as completely separate notes as one possibility.

Activity

  1. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    A-diagnosticsArea: Messages for errors, warnings, and lints
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Aug 2, 2016
  2. athulappadan commented on Aug 23, 2016

    @athulappadan
    Contributor

    Let me work on this one.

  3. sophiajt commented on Aug 24, 2016

    @sophiajt
    ContributorAuthor

    @athulappadan - I haven't heard anything on this from the first person who volunteered, so feel free to take it.

  4. added 5 commits that reference this issue on Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions