Skip to content

update ManuallyDrop RFC to reflect how the implementation now looks - #2510

Merged
nikomatsakis merged 2 commits into
rust-lang:masterfrom
RalfJung:manually-drop
Aug 9, 2018
Merged

nikomatsakis merged 2 commits into
rust-lang:masterfrom
RalfJung:manually-drop

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 1, 2018

Copy link
Copy Markdown
Member

This reflects rust-lang/rust#52711. I have no idea what the correct process is here.

Comment thread text/1860-manually-drop.md Outdated
@@ -96,6 +97,9 @@ impl<T> DerefMut for ManuallyDrop<T> {
// Other common impls such as `Debug for T: Debug`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary now.

Comment thread text/1860-manually-drop.md Outdated
The lang item will be treated specially by the compiler to not emit any drop
glue for this type.

Let us apply this union to a somewhat expanded example from the motivation:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still says union - you probably want to search the whole file.

@RalfJung

RalfJung commented Aug 1, 2018

Copy link
Copy Markdown
Member Author

Fixed nits.

@Centril Centril added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 3, 2018
@cramertj

cramertj commented Aug 9, 2018

Copy link
Copy Markdown
Member

We don't really have a process for updating RFCs, as they're generally meant to express design and intent rather than serve as a reference. That said, it seems fine to just fix this to more correctly describe a (stable) feature the language.

@nikomatsakis
nikomatsakis merged commit 4b7ff2f into rust-lang:master Aug 9, 2018
@Centril Centril added A-drop Proposals relating to the Drop trait or drop semantics A-typesystem Type system related proposals & ideas labels Nov 23, 2018
@RalfJung
RalfJung deleted the manually-drop branch September 16, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-drop Proposals relating to the Drop trait or drop semantics A-typesystem Type system related proposals & ideas T-lang Relevant to the language team, which will review and decide on the RFC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants