[mjcarroll]

Description

Fixes a leak: if StoragePolicyCommon's first rebuild throws, the destructor never runs and the rcl wait set isn't finalized. Now it's finalized before rethrowing.

Is this user-facing behavior change?

No.

Did you use Generative AI?

Claude Code (Claude Opus 5.5) found this under ASan and wrote the change; I reviewed it.

Additional Information

None.

[github-actions]

ABI Compliance Check

✅ Verdict: compatible

Library	Verdict	Summary
libcomponent_manager.so	✅ compatible	No ABI changes detected.
librclcpp.so	✅ compatible	No ABI changes detected.
librclcpp_action.so	✅ compatible	No ABI changes detected.
librclcpp_lifecycle.so	✅ compatible	No ABI changes detected.

✅ libcomponent_manager.so — full abidiff report

Compared:

• Base: lib-base/libcomponent_manager.so
• Head: lib-pr/libcomponent_manager.so @ 1e2a323

(empty report — no differences printed by abidiff)

✅ librclcpp.so — full abidiff report

Compared:

• Base: lib-base/librclcpp.so
• Head: lib-pr/librclcpp.so @ 1e2a323

Functions changes summary: 0 Removed (3 filtered out), 0 Changed (124 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

✅ librclcpp_action.so — full abidiff report

Compared:

• Base: lib-base/librclcpp_action.so
• Head: lib-pr/librclcpp_action.so @ 1e2a323

(empty report — no differences printed by abidiff)

✅ librclcpp_lifecycle.so — full abidiff report

Compared:

• Base: lib-base/librclcpp_lifecycle.so
• Head: lib-pr/librclcpp_lifecycle.so @ 1e2a323

(empty report — no differences printed by abidiff)

_{Updated for commit 1e2a323 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt}