Repository navigation
[java] Isolate batch peer decoding failures - #1586
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 A malformed batch peer currently aborts the whole Java batch. Retain each peer's decoding error separately so valid peers reach the handler and the failed peer keeps its own error through handler failures and completion retries. Return the total claim count alongside usable peers so Pro can enforce its batch limit.
This changes the internal companion-attempt API consumed by River Pro #406. Existing peer cancellation and timeout behavior is preserved. Go, Rust, JavaScript, and Ruby already isolate their corresponding peer decoding failures.
Validated with
make test/java/sqlite,RIVER_TEST_DATABASE_URL=postgres://localhost/postgres make test/java/postgres, andmake lint/javaon JDK 21. Regression coverage includes argument, row, pilot, and resumable metadata failures, later handler failures, retried durable completion, and the existing cancellation tests.