Repository navigation
[PHPUnit100] Add willReturnOnConsecutiveCalls() variables to closure use() in WithConsecutiveRector - #821
Merged
TomasVotruba merged 1 commit intoNov 9, 2026
Conversation
…use() in WithConsecutiveRector
TomasVotruba
deleted the
fix-will-return-on-consecutive-calls-use-variables
branch
November 9, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9962
WithConsecutiveRectorbuilt thewillReturnCallback()closure'suse()list from thewithConsecutive()args and the single return statement only. ThewillReturnOnConsecutiveCalls()return values are injected into the if-branches afterwards byWillReturnIfNodeDecorator, so variables used there (e.g.$title) were never captured, producing a closure that fails with "Undefined variable".Now the
willReturnOnConsecutiveCalls()call is passed intoUsedVariablesResolverso its args' variables are added touse()too.Before:
After:
Added a fixture covering the reported case.