Repository navigation
Fix Windows path separator handling in lint-markdown-code-blocks - #8742
Open
ShakilUrRehman21 wants to merge 1 commit into
Open
ShakilUrRehman21 wants to merge 1 commit into
ShakilUrRehman21 wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
eslint-local-rules/rules/lint-markdown-code-blocks.js, the rule checks!filename.includes('src/content'). On Windows,context.getFilename()returns native backslash separators (src\content), causing:yarn test:eslint-local-rulesto fail out-of-the-box withAssertionError: expected one diagnostic: 0 !== 1because the rule exits early on test fixtures.eslint "src/content/**/*.md"/yarn lintto silently bypass all markdown documents on Windows developer machines.This PR normalizes
context.getFilename()separators to forward slashes before testing path inclusion.How was this tested?
yarn test:eslint-local-rules(now passes cleanly in 4s; previously failed).eslint "src/content/**/*.md"actively checks markdown code blocks on Windows.yarn tscandnpx prettier --check eslint-local-rules/rules/lint-markdown-code-blocks.js.