Repository navigation
Fix cross-platform path handling in RSS feed generator - #8741
Open
ShakilUrRehman21 wants to merge 1 commit into
Open
ShakilUrRehman21 wants to merge 1 commit into
ShakilUrRehman21 wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
src/utils/rss.js, the slug generation logic relied onfilePath.split('/'). On Windows environments wherepath.joinproduces backslash separators,split('/')does not split the path, resulting in the absolute machine filesystem path being baked into<link>and<guid>elements inpublic/rss.xml(e.g.,https://react.dev/blog/D:\OpenSource\react.dev\src\content\blog\2026\09\09\react-19-3).This PR:
path.relative(dirPath, filePath)and forward-slash normalization.path.join(dirPath, file)ingetAllFilesinstead of string concatenation.How was this tested?
node scripts/generateRss.jslocally.public/rss.xmlnow generate valid permalinks (e.g.https://react.dev/blog/2026/09/09/react-19-3).yarn tscandnpx prettier --check src/utils/rss.js.