Skip to content

fix: exclude tvOS headers from ReactCommon and ReactAndroid C++ snapshots - #60201

Open
jipeng6036-del wants to merge 1 commit into
react:mainfrom
jipeng6036-del:fix/cxx-api-tvos-snapshots
Open

jipeng6036-del wants to merge 1 commit into
react:mainfrom
jipeng6036-del:fix/cxx-api-tvos-snapshots

Conversation

@jipeng6036-del

Copy link
Copy Markdown
Contributor

Summary:

ReactCommon and ReactAndroid include tvOS headers when generating their C++ API snapshots. This makes ReactCommon advertise the tvOS HostPlatformViewProps class and lets Doxygen merge that class into Android's. Exclude the tvOS platform directory from those two views and regenerate their eight snapshots.

Fixes #60180. Thanks to @YevheniiKotyrlo for showing which headers enter each view and how the overlap affects the generated Android API.

Changelog:

[Internal] [Fixed] - Keep tvOS headers out of the ReactCommon and ReactAndroid C++ API snapshots.

Test Plan:

  • Compared the platform headers selected by the repository parser before and after the change. ReactCommon selects neither platform header and ReactAndroid selects only its own.
  • Ran yarn cxx-api-build and yarn cxx-api-validate with Doxygen 1.16.1 in Linux. All 12 snapshots matched on a second generation.
  • Ran python -m unittest scripts/cxx-api/tests/test_*.py (313 passed).

Code and verification assisted by Codex.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 21, 2026
@github-actions

Copy link
Copy Markdown

Visual regression

1 visual difference(s) at ff949d43d80b. Visual differences need maintainer approval. Review the report, then apply visual-change-approved.

ios border/corner-radii/default: Changed, 68005 px (75.561%)

diff

Expected and Captured
Expected Captured
expected captured

@jipeng6036-del

Copy link
Copy Markdown
Contributor Author

I checked the iOS report for ff949d43. The captured border/corner-radii/default image is covered by a system Settings banner that isn't in the baseline. This PR changes the C++ API snapshot configuration and generated snapshots. Could a maintainer rerun the iOS visual check for this commit?

Visual report

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++ API snapshots: ReactCommon and ReactAndroid read the tvOS view headers, as scripts/cxx-api/config.yml does not exclude */platform/tvos/*

1 participant