Repository navigation
fix: exclude tvOS headers from ReactCommon and ReactAndroid C++ snapshots - #60201
Open
jipeng6036-del wants to merge 1 commit into
Open
jipeng6036-del wants to merge 1 commit into
jipeng6036-del wants to merge 1 commit into
Conversation
Contributor
Author
|
I checked the iOS report for |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
ReactCommon and ReactAndroid include tvOS headers when generating their C++ API snapshots. This makes ReactCommon advertise the tvOS
HostPlatformViewPropsclass and lets Doxygen merge that class into Android's. Exclude the tvOS platform directory from those two views and regenerate their eight snapshots.Fixes #60180. Thanks to @YevheniiKotyrlo for showing which headers enter each view and how the overlap affects the generated Android API.
Changelog:
[Internal] [Fixed] - Keep tvOS headers out of the ReactCommon and ReactAndroid C++ API snapshots.
Test Plan:
yarn cxx-api-buildandyarn cxx-api-validatewith Doxygen 1.16.1 in Linux. All 12 snapshots matched on a second generation.python -m unittest scripts/cxx-api/tests/test_*.py(313 passed).Code and verification assisted by Codex.