Skip to content

Report registered components in Fantom view manager queries - #60129

Open
jipeng6036-del wants to merge 1 commit into
react:mainfrom
jipeng6036-del:fix/fantom-view-manager-lookup
Open

jipeng6036-del wants to merge 1 commit into
react:mainfrom
jipeng6036-del:fix/fantom-view-manager-lookup

Conversation

@jipeng6036-del

Copy link
Copy Markdown
Contributor

Summary

Fixes #60064.

Make Fantom's view manager lookup use the same component descriptor providers as its renderer. It applies the renderer's name normalization, so View and RCTView resolve to the registered provider. Unknown names still return false.

Thanks to @YevheniiKotyrlo for the reproduction. Codex helped implement and verify this change.

Changelog

[INTERNAL] [FIXED] - Report registered view managers in Fantom.

Test Plan

  • With the upstream CI Fantom binary from the unchanged baseline, yarn fantom --runInBand packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.js reproduced the incorrect false for View. The unregistered-name control passed.
  • On Linux, rebuilt the tester with yarn workspace @react-native/fantom build and ran yarn fantom --runInBand packages/react-native/Libraries/ReactNative/__tests__. All 7 tests passed, including the registered name, legacy alias, and unregistered name cases.
  • Ran yarn eslint --max-warnings 0 and yarn prettier --check on the new test, and clang-format --dry-run --Werror on the three changed C++ files.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

1 participant