Skip to content

V1 -- Remove --open call on npm start #47

Closed

Description

@sthzg

As brought up in generator-react-webpack #266

V1

  • remove open() method in server.js
  • log dev server address to console after the inital webpack build is ready

Activity

  1. self-assigned this
    on Aug 11, 2016
  2. sthzg commented on Aug 11, 2016

    @sthzg
    MemberAuthor

    @weblogixx it will now print the following info to the shell after the initial build (on V1 of the template).

    bildschirmfoto 2016-08-11 um 12 14 13

  3. weblogixx commented on Aug 11, 2016

    @weblogixx
    Member

    Seems like a nice addition. Do you think we should wait a bit until more 1.x features are there or do you want to push it directly? I do not think that we will have any more advanced features for the current stable, so pushing would ok.

  4. sthzg commented on Aug 11, 2016

    @sthzg
    MemberAuthor

    I think waiting is absolutely okay. I just want to merge it so that I can delete the feature branch. Besides being a topic in the browser sync issue it's not such an important change, after all.

  5. added a commit that references this issue on Aug 11, 2016
    0e8d82a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions