Repository navigation
PENDING: PCI/bwctrl: Include link width in OPP frequency key - #1475
Open
krishnachaitanya-linux wants to merge 1 commit into
Open
krishnachaitanya-linux wants to merge 1 commit into
krishnachaitanya-linux wants to merge 1 commit into
Conversation
pcie_set_opp() looks up the OPP using only the per-lane link speed as the frequency key, ignoring the negotiated link width. The OPP table frequency is the aggregate rate across all lanes, so the lookup picks the wrong entry (or none) for links wider than x1. Scale the key frequency by the current link width, consistent with the value already reported in the error message. Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Test resultsWorkflow run: 44258350036 attempt 1 Known failures configured: 0
Test Matrix
Failure summaryUnexpected failures
Result: blocked because unexpected failures were found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcie_set_opp() looks up the OPP using only the per-lane link speed as the frequency key, ignoring the negotiated link width. The OPP table frequency is the aggregate rate across all lanes, so the lookup picks the wrong entry (or none) for links wider than x1.
Scale the key frequency by the current link width, consistent with the value already reported in the error message.