Skip to content

PENDING: PCI/bwctrl: Include link width in OPP frequency key - #1475

Open
krishnachaitanya-linux wants to merge 1 commit into
qualcomm-linux:qcom-7.3from
krishnachaitanya-linux:bwctrl-opp-freq-width
Open

krishnachaitanya-linux wants to merge 1 commit into
qualcomm-linux:qcom-7.3from
krishnachaitanya-linux:bwctrl-opp-freq-width

Conversation

@krishnachaitanya-linux

Copy link
Copy Markdown
Contributor

pcie_set_opp() looks up the OPP using only the per-lane link speed as the frequency key, ignoring the negotiated link width. The OPP table frequency is the aggregate rate across all lanes, so the lookup picks the wrong entry (or none) for links wider than x1.

Scale the key frequency by the current link width, consistent with the value already reported in the error message.

pcie_set_opp() looks up the OPP using only the per-lane link speed as
the frequency key, ignoring the negotiated link width. The OPP table
frequency is the aggregate rate across all lanes, so the lookup picks
the wrong entry (or none) for links wider than x1.

Scale the key frequency by the current link width, consistent with the
value already reported in the error message.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
@qcomlnxci

Copy link
Copy Markdown

Test results

Workflow run: 44258350036 attempt 1

Known failures configured: 0

Target Pass Non-pass Total
kbdev-glymur-crd-multimedia 31 5 36

Test Matrix

Test Case kbdev-glymur-crd-multimedia
LAVA result ✅ Results
Audio_Card_Registration ✅ Pass
BT_FW_KMD_Service ✅ Pass
BT_ON_OFF ✅ Pass
BT_SCAN ✅ Pass
CPUFreq_Validation ✅ Pass
CPU_affinity ✅ Pass
DSP_AudioPD ✅ Pass
Ethernet_Basic_Validation ⚠️ skip
Freq_Scaling ✅ Pass
GIC ✅ Pass
IPA ✅ Pass
Interrupts ✅ Pass
KVM_Driver ✅ Pass
KVM_EL2_DTB ✅ Pass
KVM_Infra ✅ Pass
OpenCV ✅ Pass
PCIe ✅ Pass
Probe_Failure_Check ❌ Fail
RMNET ✅ Pass
UFS_Validation ⚠️ skip
USBHost ✅ Pass
WiFi_Firmware_Driver ✅ Pass
WiFi_OnOff ✅ Pass
adsp_remoteproc ✅ Pass
cdsp_remoteproc ✅ Pass
gpdsp_remoteproc ⚠️ skip
hotplug ✅ Pass
irq ✅ Pass
kaslr ✅ Pass
pinctrl ✅ Pass
qcom_hwrng ✅ Pass
rngtest ✅ Pass
shmbridge ✅ Pass
smmu ❌ Fail
watchdog ✅ Pass
wpss_remoteproc ✅ Pass
Failure summary

Unexpected failures

  • kbdev-glymur-crd-multimedia: gpdsp_remoteproc => skip.
  • kbdev-glymur-crd-multimedia: Probe_Failure_Check => fail.
  • kbdev-glymur-crd-multimedia: smmu => fail.
  • kbdev-glymur-crd-multimedia: UFS_Validation => skip.
  • kbdev-glymur-crd-multimedia: Ethernet_Basic_Validation => skip.

Result: blocked because unexpected failures were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants