Repository navigation
Conversation
c2981e6 to
9824149
Compare
c2987cb to
ffb6892
Compare
d0031ad to
df6065f
Compare
|
I'll rebase this again after #9908 gets merged since this builds on it 👍 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Rebased on the freshly rebased |
|
Rebased on the once more freshly rebased ft-clarify, now with release notes targeting version 13.1.0. |
I'm not sold on the need for this. It's rare that many test images need to be updated at once. For most scenarios, if you're writing tests, you can simply
|
This is a PR where I needed to do just that, and doing it manually seemed like a chore, since there were lots of affected tests, scattered throughout.
Sure, and such a PR would probably be tagged in review, right, just like any change..? Either way I'm not convinced there's a huge risk of inadvertent usage, as you'd have to find the envvar, turn it on, then notice that "huh, a lot of files have changed, wonder why, ah well, I'll commit them anyway", and make a PR with all of them? Either way, I can rip out the commit that adds that switch if you like. |
| // from the font's design over longer spans. | ||
| // Monochrome and bitmap glyphs retain grid-fitted metrics so they render | ||
| // with suitable crispness. | ||
| int unfitted = !mask && glyph->format == FT_GLYPH_FORMAT_OUTLINE; |
There was a problem hiding this comment.
Why not always use FT_KERNING_UNFITTED?
There was a problem hiding this comment.
IIRC (it's been nearly 3 months since I wrote this), to keep the promise of the comment above.
FT_KERNING_UNFITTED on 1-bit would have FT raster onto subpixel positions that can't be a thing on 1-bit output (IIRC).
I can cook up a comparison if you like.
(and make `assert_image_equal` raise an AssertionError, not a pytest.fail.Exception)
Refs #9898 (not "fixes", since I can't be sure this ends up fixing OP's issues).
What's moving?
Some infrastructure:
PILLOW_TEST_SNAPSHOTScan now be set tocreate,overwriteorupdate, soassert_image_similar_tofileandassert_image_equal_tofilecan update the golden image to what was passed in; this is similar to--snapshot-updatefor Syrupy orINSTA_UPDATEfor Rust's Insta.These are the actual fixes; see #9908 for notes on the clean-ups:
(unsigned char)cast.