Repository navigation
Remove expired record in del() instead of leaking it - #117
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
When del() was called on a record whose expire time had passed but whose timeout had not fired yet, it cleared the timeout and returned false without removing the record. The entry then stayed in the cache forever, still counted by size(), keys() and memsize(). Fixes ptarjan#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
del()hit a record whose expire time had passed but whose timeout hadn't fired yet, it cleared the timeout and returned false without removing the record. The entry then stayed in the cache permanently and was still counted bysize(),keys()andmemsize(). This removes it in that case too, and still returns false. I added a test using the fake clock.Fixes #96