Skip to content

Resolves #9291: Add bezierVertex(x,y,[u],[v]) overload - #9294

Open
BRNMan wants to merge 3 commits into
processing:mainfrom
BRNMan:bezierVertex_overload
Open

Resolves #9291: Add bezierVertex(x,y,[u],[v]) overload#9294
BRNMan wants to merge 3 commits into
processing:mainfrom
BRNMan:bezierVertex_overload

Conversation

@BRNMan

@BRNMan BRNMan commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Resolves #9291

Changes:
Moves bezierVertex from vertex.js to custom_shapes.js and adds x,y,u,v overloading the same way splineVertex does it.
You can now texture a 2D bezier vertex.

PR Checklist

@welcome

welcome Bot commented Oct 15, 2026

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@BRNMan
BRNMan force-pushed the bezierVertex_overload branch from a8d866f to e25a8dc Compare October 26, 2026 21:01
@p5-bot

p5-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: e25a8dc

Previous deployments

This is an automated message.

ksen0
ksen0 reviewed Nov 4, 2026
View reviewed changes
Comment thread src/shape/custom_shapes.js
* @param {Number} [u]
* @param {Number} [v]
*/
fn.bezierVertex = function (...args) {

@ksen0 ksen0 Nov 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overload functionality could use test coverage I think!

@BRNMan BRNMan Nov 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I've just added some visual tests for the 2d and 3d cases for spline and bezier vertices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksen0 ksen0 ksen0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[p5.js 2.0+ Bug Report]: WebGL - bezierVertex(x,y,u,v) overload won't texture map correctly

2 participants

@BRNMan @ksen0