Skip to content

fix:#9244. fix(nfc): round and pad decimals to requested precision - #9283

Open
vinayaksingh108 wants to merge 3 commits into
processing:mainfrom
vinayaksingh108:new-fix
Open

vinayaksingh108 wants to merge 3 commits into
processing:mainfrom
vinayaksingh108:new-fix

Conversation

@vinayaksingh108

Copy link
Copy Markdown

Summary

  • Make nfc() round and pad decimal places when a precision is provided.
  • Preserve the existing formatting when precision is omitted.
  • Add regression tests for rounding, padding, zero precision, negative values, and arrays.

Validation

  • Focused utility tests: 31 passed
  • Oxlint: passed for the changed files

AI use

AI assistance was used to help implement and validate this change; I reviewed the changes and tests.

@welcome

welcome Bot commented Oct 13, 2026

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@vinayaksingh108 vinayaksingh108 changed the title fix(nfc): round and pad decimals to requested precision fix(nfc): round and pad decimals to requested precision #9245 Oct 13, 2026
@vinayaksingh108 vinayaksingh108 changed the title fix(nfc): round and pad decimals to requested precision #9245 fix(nfc): round and pad decimals to requested precision #9244 Oct 13, 2026
@vinayaksingh108 vinayaksingh108 changed the title fix(nfc): round and pad decimals to requested precision #9244 fix:#9244. fix(nfc): round and pad decimals to requested precision Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant