Repository navigation
fix(data): add early returns to storeItem and removeItem validation - #9250
Open
iUjjwalRaj wants to merge 1 commit into
Open
iUjjwalRaj wants to merge 1 commit into
iUjjwalRaj wants to merge 1 commit into
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
iUjjwalRaj
force-pushed
the
fix/store-item-validation-return
branch
from
October 7, 2026 08:18
6101aed to
edaff2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/data/local_storage.js, add missingreturn;statements to each validation branch instoreItem()(typeof key !== 'string',key.endsWith('p5TypeID'), andtypeof value === 'undefined') andremoveItem()(typeof key !== 'string').TypeError: key.endsWith is not a functionwhen a numeric key is passed, and preventingundefinedvalues from being written tolocalStorage.storeItem and removeItem input validationintest/unit/data/local_storage.jsverifying proper early return handling for non-string keys, invalid suffix keys, and undefined values.Fixes #9242
Validation
npx vitest run test/unit/data/local_storage.jspassed (21/21 unit tests).npm run lintpassed (0 errors).git diff --checkpassed cleanly.