Repository navigation
Conversation
…lows In Auto, antigravityPermissionDisposition answered every non-denied request with "ask" on the premise that agy's Auto had already reviewed it. agy's Auto reviews commands, not file reads: it still sends a read-kind permission request for any path outside its workspace, so every such read became an approval card, although Supervised and Auto-accept edits allow the same request. Read kinds now follow the shared policy; everything else in Auto still asks, and sandbox denials still deny. Fixes pingdotgg#40127 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Problem
In an Antigravity thread in Auto, every file read outside the thread's working directory shows an approval card, while Supervised and Auto-accept edits allow the same reads. One delegated review subagent, running in an Auto thread whose project wasn't the repo under review, raised 32 cards, all
Read <file>; the first held the turn for about 7.5 minutes. Seen on T3 Code 0.1.12-nightly.20261120.4994, agy 1.5.13, macOS arm64, Google sign-in.Change
antigravityPermissionDispositionanswered every non-denied Auto request withask, on the premise that agy's Auto has already reviewed what it sends. For file reads it hasn't: in that session each of the 32 reads logsagy_tool_safety FINISHED: triggered=false, reason="allowed_tool"andsir_flash_lite SKIPPED, so agy's Auto review model never looked at them. agy sends the request because the path is outside its workspace (capture below), the same request it sends in every mode. In the same session,git status/git diffandgit grepon that repo went through agy's review, and none of them reached T3 as a permission request.Read kinds (
read,search,think, via the sharedisAcpReadKind, now exported) now follow the shared policy in Auto, as in every other mode. Every other kind agy sends in Auto still asks (execute,edit/delete/move,fetch,other, missing), and sandbox denials still deny.Scope
Fixes #40127. This narrows review finding R1-F3 of #39378 to non-read requests. R1-F3 made read-kind requests ask in Auto, on the premise that anything agy sends in Auto is an escalation its review refused. The log above shows that isn't true for reads, and #13584 already decided that read-kind permission requests follow the sandbox and never ask. Grok and fx keep ask-everything in Auto: their Auto prompts are classifier refusals, and Grok never sends read requests (#13584).
The same change closes the gap CodeRabbit flagged on #39378: an Auto thread on an account without native Auto shows Supervised, but still asked for reads that Supervised allows.
#39822 edits the same
returnline for T3 MCP tools. The two compose (deny, then T3 MCP allow, then reads follow the shared policy, then ask); I'll rebase on it if it lands first.This keeps the fix to the existing modes. Whether Auto should also allow non-workspace access more broadly could instead be a per-provider setting: agy already has
allowNonWorkspaceAccessin itssettings.json, and with it set agy sends no request for these reads at all, but T3 rewrites that file on every launch. That would be a separate change, so it isn't part of this PR.Verification
AntigravityAcpSupport.test.tsnow expectsallowforreadandaskforexecuteandfetch. Thereadrow fails onmainand passes with the fix; the sandbox-denial test still passes.vp run check:changedpasses: format, lint, knip, typecheck (14 packages), tests.vp run dev --no-seed) with agy 1.5.13 and a Google sign-in (native Auto offered), Gemini 3.8 Flash, permission mode Auto, projectdemo/app, prompt: "Use your file viewing tool (not a shell command) to read ../shared/notes.txt and tell me the release codename."main: theRead …/demo/shared/notes.txtrow waits for approval ("Waiting for approval · Allow once · Deny · More"), and the thread shows Approval.(Home path and machine name blacked out.)
agy acp1.5.13 with the same sign-in:session/newoffersdefault, accept-edits, auto, plan;session/set_modetoautoreturns{}; a file-tool read outside the cwd then arrives as (trimmed):{"toolCall": {"name": "read_file", "kind": "read", "status": "pending", "locations": [{"path": "/Users/<me>/<other-repo>/README.md"}]}, "options": [{"optionId": "allow", "kind": "allow_once"}, {"optionId": "deny", "kind": "reject_once"}]}readrow uses a request of the same kind.search- orthink-kind requests live (I haven't seen agy send them), and a session without native Auto.Fix designed and first drafted with Gemini 4 Neon (Antigravity in T3 Code); final code and tests written with Claude Opus 5.5 in Claude Code (T3 Code). Reviewed with Claude Fable 5.2, Claude Opus 5.5 and Gemini 4 Neon.
🤖 Generated with Claude Code