Skip to content

fix(antigravity): accept null skill manifest lists - #40287

Open
Lucenx9 wants to merge 1 commit into
pingdotgg:mainfrom
Lucenx9:fix/antigravity-null-skill-manifest
Open

Lucenx9 wants to merge 1 commit into
pingdotgg:mainfrom
Lucenx9:fix/antigravity-null-skill-manifest

Conversation

@Lucenx9

@Lucenx9 Lucenx9 commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Problem

Antigravity loads skills from a skills.json manifest with optional list fields set to null. T3 discards the entire manifest in that case, so loaded skills can disappear from the picker.

Change

Accept null in entries, inherits, include_only, and exclude. The existing fallback paths treat a null list like an omitted list. Paths and elements in non-null lists still go through the same schema.

Scope

This is a small Antigravity discovery fix. It leaves manifest paths, filter matching, and scan budgets alone. A targeted search found no equivalent PR.

Verification

I compared the Antigravity 1.5.13 ACP command list with T3's discovery using the same manifest and workspace. Both ran against temporary data on Linux. The native CLI ran offline without a model turn.

Same manifest Native CLI T3 before T3 after
Three fixture skills, with optional lists set to null 3 skills 0 skills 3 skills
Each nullable field in isolation 1 skill 0 skills 1 skill
Omitted-field control 1 skill 1 skill 1 skill

The extended manifest test failed on base because the workspace skill was missing. The test still covers inherited settings, a cycle, and a nonempty exclusion.

fast-check passed 120 cases and Jazzer.js completed 240 bounded runs. Stryker generated no mutants on the four schema lines. Four separate negative controls each removed one null case and failed as expected. Fallow passed on a two-file snapshot. CodeScene flagged the extra fixture lines inside the existing test factory, with cyclomatic complexity unchanged.

vp run check:changed --concurrency 1 passed after aligning dependencies with the lockfile: 16 tests, typecheck, format, lint, Knip and GraphQL. The check passed again after rebasing onto 0dc32b5. Normal commit hooks passed.

Independent review: Gemini 4 Neon medium on Antigravity and Opus 5.5 high approved.

Reviewed with sol-loop: 1 round with GPT-6.2 Sol on high. Sol verdict: approved.

Created with GPT-6.2 Sol in Codex through T3 Code.

Copilot AI balanced review requested due to automatic review settings November 21, 2026 11:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T11:21:43.988125Z fdc72cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The skill configuration schema now accepts null for selected fields. The test fixture covers null-valued fields and relative workspace inheritance. The filter entry parameter now uses the schema-derived type.

Changes: Nullable skill configuration

Layer / File(s) Summary
Schema and fixture coverage
apps/server/src/provider/Drivers/AntigravitySkills.ts, apps/server/src/provider/Drivers/AntigravitySkills.test.ts
The schema allows null for include_only, exclude, inherits, and entries. narrowSkillFilter derives its entry parameter type from SkillConfigEntry. The fixture adds null-valued fields and relative workspace inheritance.

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: bugfix

Suggested reviewers: mameli, juliusmarminge

Merge Risk: Minimal · up to fdc72

Antigravity skill manifests with null list fields will now be discovered instead of being rejected. The change is narrow, tests cover the null cases, and no merge-blocking risk is identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(antigravity): accept null skill manifest lists" matches the main change. The diff makes the Antigravity skill schema accept null for entries, inherits, include_only, and exclude. It use…
Description check Passed The description follows the repository template. It has Problem, Change, Scope, and Verification sections. The Problem section states the bug: a null list makes T3 discard the whole manifest, so skill…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(antigravity): accept null skill manifest lists" matches the main change. The diff makes the Antigravity skill schema accept null for entries, inherits, include_only, and exclude. It uses a conventional commit prefix and names the component and the behavior.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope, and Verification sections. The Problem section states the bug: a null list makes T3 discard the whole manifest, so skills disappear. The Change section lists the four fields and the fallback behavior. The Scope section explains the limits of the fix and states that no equivalent PR was found, but it does not link an issue or explain why no issue is needed for this small fix. The Verification section gives a before-and-after comparison table and test results. It also names the model and harness used. The template asks for a link to the issue showing the bug, or a reason no issue is needed, so that item is incomplete. The description also says that the author ran checks on the author's own machine, and it does not include a link to an issue or a maintainer request.

Resolution

Consider adding a link to the issue that shows the bug. If no issue exists, state briefly why this small fix needs none. The description is otherwise complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0dc32b5 and fdc72cd.

Files selected for processing: 2

  • apps/server/src/provider/Drivers/AntigravitySkills.test.ts
  • apps/server/src/provider/Drivers/AntigravitySkills.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). takeover:in-progress A takeover lead is working on this PR vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants