Repository navigation
Conversation
Girgias
left a comment
There was a problem hiding this comment.
I was slightly confused why the php_token_ce is unused, the reason is that PHP_METHOD(PhpToken, tokenize) gets the token class via: token_class = zend_get_called_scope(execute_data); which may seems odd at first, but it's to allow the class to be extended and creates instances of the subclass. (Which probably should have a comment to explain it).
The zend_test are quite obviously correct.
For the user_filter_class_entry it currently makes sense as it is only ever used as an "implicit" requirement to be extended, but I've thought that maybe we should require that registering a userland filter extends from it. But then the API is very clunky (defining onCreate/onClose methods rather than using normal constructor/destructor) so maybe creating a new interface would just be better.
| static php_rfc1867_encoding_translation_t php_rfc1867_encoding_translation = dummy_encoding_translation; | ||
| static php_rfc1867_get_detect_order_t php_rfc1867_get_detect_order = NULL; | ||
| static php_rfc1867_set_input_encoding_t php_rfc1867_set_input_encoding = NULL; | ||
| static php_rfc1867_set_input_encoding_t ZEND_ATTRIBUTE_UNUSED php_rfc1867_set_input_encoding = NULL; |
There was a problem hiding this comment.
Must the unused attribute be placed here? Can it not be at the front?
Clang 23 complains about static globals that are set but never read