Repository navigation
pfFilterResults: Update Results Count Label to PatternFly Design #721
Description
Here is the current impl.:
Here is the Patternfly Design:
- The results count label is left aligned, where it needs to be right aligned
- When there are active filters the results count label should say "n of m Items"
- 'Items' can be user defined. Ex: "Virtual Machines" (I think this last part is already implemented, pls verify).
- When there are no active filters the results count label should say "m Items".
- Can/Should we make the results count label optional? See pfToolbar: make filter results count optional #717 & pfToolbar: only show second toolbar row when there are active filters #720. @LHinson, @beanh66
Related Issue: #720
Activity
dtaylor113 commentedon Feb 23, 2018
Related open issue in patternfly-design: patternfly/patternfly-design#576
jcaianirh commentedon Mar 12, 2018
@dtaylor113 I started looking at this issue, and found the following while looking at the current behavior:
Indeed results is currently left aligned. According to this patternfly core issue, the results may need to stay left justified, but maybe @serenamarie125 or @beanh66 can help with this: Filter bar component is inconsistent throughout PF documentation patternfly-design#576
When there are active filters the results will say "n of m items" if the showTotalCountResults option is set to true. (Done in existing codebase)
Items are user defined. I can add a custom label using itemsLabel and itemsLabelPlural. (Done in existing codebase)
When there are no active filters, the results count label says "m items" (Done in existing codebase)
@beanh66 and @LHinson do we want the results count label to be optional? (Need some clarification on this)
mcarrano commentedon Aug 30, 2018
Note that the placement of the filter results should always be on the left. This is inconsistent in some of the design pages and we are currently working to clean that up. Please follow this spec for the correct implementation: https://www.patternfly.org/pattern-library/forms-and-controls/filter/#design You'll note that the term "Items" is considered a default, but may be replaced by a more specific term when that makes sense.