Skip to content

test: make test-doc-api-json more robust - #67701

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/test-doc-api-json-improvement
Open

jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/test-doc-api-json-improvement

Conversation

@jasnell

@jasnell jasnell commented Nov 22, 2026

Copy link
Copy Markdown
Member

The test hard coded the number of deprecated apis
so whenever one is added or removed it always needs to be updated. This makes the check more robust by calculating the values on each run.

/cc @nodejs/doc-kit

The test hard coded the number of deprecated apis
so whenever one is added or removed it always needs
to be updated. This makes the check more robust by
calculating the values on each run.

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Nov 22, 2026

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Nov 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.55%. Comparing base (d46aecc) to head (28c6c20).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67701   +/-   ##
=======================================
  Coverage   90.54%   90.55%           
=======================================
  Files         801      801           
  Lines      284109   284109           
  Branches    54870    54878    +8     
=======================================
+ Hits       257253   257261    +8     
+ Misses      17020    17013    -7     
+ Partials     9836     9835    -1     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 22, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 22, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants