Repository navigation
Conversation
The test hard coded the number of deprecated apis so whenever one is added or removed it always needs to be updated. This makes the check more robust by calculating the values on each run. Signed-off-by: James M Snell <jasnell@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67701 +/- ##
=======================================
Coverage 90.54% 90.55%
=======================================
Files 801 801
Lines 284109 284109
Branches 54870 54878 +8
=======================================
+ Hits 257253 257261 +8
+ Misses 17020 17013 -7
+ Partials 9836 9835 -1 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test hard coded the number of deprecated apis
so whenever one is added or removed it always needs to be updated. This makes the check more robust by calculating the values on each run.
/cc @nodejs/doc-kit