Repository navigation
node-api: reject detaching immutable arraybuffers - #67388
fatihguzeldev wants to merge 1 commit into
Conversation
return napi_detachable_arraybuffer_expected for immutable arraybuffers instead of aborting when v8 rejects the detach operation. Refs: nodejs#66346 Signed-off-by: Fatih GΓΌzel <fatihguzeldev@gmail.com>
|
Review requested:
|
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67388 +/- ##
==========================================
- Coverage 92.62% 90.72% -1.91%
==========================================
Files 430 798 +368
Lines 196333 280076 +83743
Branches 29897 53886 +23989
==========================================
+ Hits 181849 254089 +72240
- Misses 14159 16276 +2117
- Partials 325 9711 +9386
π New features to boost your workflow:
|
|
Why does V8 consider an immutable According to the proposal:
So, shouldnβt an immutable |
|
I agree, this sounds like should be fixed in V8. |
|
i hadn't thought of it that way, but i think you guys are right. i'm still new around here. i'll see if i can fix this in v8. |
|
i opened a fix in v8: https://chromium-review.googlesource.com/c/v8/v8/+/8829814 |
|
Once that lands, we'll need to make sure to follow up with a cherry-pick into our vendored v8 |
napi_detach_arraybuffer() aborts when passed an immutable arraybuffer.
return napi_detachable_arraybuffer_expected instead.
Refs: #66346