Repository navigation
[utils] perf: reuse the quoted-string regular expression - #13150
Open
pengbanban wants to merge 1 commit into
Open
pengbanban wants to merge 1 commit into
pengbanban wants to merge 1 commit into
Conversation
Signed-off-by: pengbanban <pengqichugui@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EscapeNewLinesrecompiles the same quoted-string regular expression for every call made by function-output parsing and grammar generation. Compile it once at package initialization, as is already done for the newline matcher.Notes for Reviewers
Ginkgo/Gomega cases preserve escaped quotes, newlines inside strings, and formatting whitespace outside strings. A focused benchmark measured 54 allocations per call before the change and 16 afterwards in the initial same-input harness; the final package benchmark also reports 16. These are microbenchmark allocation results, not an application-throughput claim.
The focused package suite passed 4 specs. The complete app build, model suites and
make lintwere not run.Signed commits