Repository navigation
Build kissat for macOS 11.0 and check the bundle's minimum macOS - #5161
Open
feliperodri wants to merge 1 commit into
Open
feliperodri wants to merge 1 commit into
feliperodri wants to merge 1 commit into
Conversation
The bundled kissat is built from source on the release runner, so it targets the runner's macOS. Since the x86_64 bundle moved to macos-15-intel (model-checking#4442), its kissat requires macOS 15.0, and with model-checking#5138 the aarch64 kissat does too (0.68.0 shipped one requiring 14.0). Every other binary in the bundle targets 11.0. Set MACOSX_DEPLOYMENT_TARGET=11.0 for the kissat build on macOS, and fail the macOS bundle builds when any bundled binary requires a newer macOS, so the next runner upgrade cannot drop support silently. Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release bundle's
kissatis built from source on the release runner (scripts/setup/install_kissat.sh). With no deployment target set, the compiler targets the runner's own macOS version. Every other bundled binary targets macOS 11.0, but kissat now requires a newer macOS:kissatminimum macOSmacos-14macos-15macos-15-intel(since #4442)(These were read from each binary's
LC_BUILD_VERSION/LC_VERSION_MIN_MACOSX.) The next release would therefore ship a kissat that fails to load on macOS 14 and older.This PR:
MACOSX_DEPLOYMENT_TARGET=11.0for the kissat build on macOS, matching rustc's default for both macOS targets;build-bundleaction that fails a macOS bundle build if any bundled binary requires a macOS newer than 11.0, so a future runner upgrade cannot drop support silently.Testing: the
BuildBundle-MacOs-x86_64job in this PR's CI runs the new check.BuildBundle-MacOs-aarch64still runs on the retiredmacos-14runner until #5138 merges, so the aarch64 bundle is checked after that. The version comparison was tested locally against sampleotool -loutput.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.