Skip to content

Build kissat for macOS 11.0 and check the bundle's minimum macOS - #5161

Open
feliperodri wants to merge 1 commit into
model-checking:mainfrom
feliperodri:kissat-deployment-target
Open

feliperodri wants to merge 1 commit into
model-checking:mainfrom
feliperodri:kissat-deployment-target

Conversation

@feliperodri

Copy link
Copy Markdown
Member

The release bundle's kissat is built from source on the release runner (scripts/setup/install_kissat.sh). With no deployment target set, the compiler targets the runner's own macOS version. Every other bundled binary targets macOS 11.0, but kissat now requires a newer macOS:

Bundle Runner kissat minimum macOS Other binaries
aarch64, 0.68.0 release macos-14 14.0 11.0
aarch64, built in #5138 macos-15 15.0 11.0
x86_64, built in #5138 macos-15-intel (since #4442) 15.0 10.12–10.15

(These were read from each binary's LC_BUILD_VERSION / LC_VERSION_MIN_MACOSX.) The next release would therefore ship a kissat that fails to load on macOS 14 and older.

This PR:

  • sets MACOSX_DEPLOYMENT_TARGET=11.0 for the kissat build on macOS, matching rustc's default for both macOS targets;
  • adds a step to the build-bundle action that fails a macOS bundle build if any bundled binary requires a macOS newer than 11.0, so a future runner upgrade cannot drop support silently.

Testing: the BuildBundle-MacOs-x86_64 job in this PR's CI runs the new check. BuildBundle-MacOs-aarch64 still runs on the retired macos-14 runner until #5138 merges, so the aarch64 bundle is checked after that. The version comparison was tested locally against sample otool -l output.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

The bundled kissat is built from source on the release runner, so it targets
the runner's macOS. Since the x86_64 bundle moved to macos-15-intel (model-checking#4442),
its kissat requires macOS 15.0, and with model-checking#5138 the aarch64 kissat does too
(0.68.0 shipped one requiring 14.0). Every other binary in the bundle
targets 11.0.

Set MACOSX_DEPLOYMENT_TARGET=11.0 for the kissat build on macOS, and fail the
macOS bundle builds when any bundled binary requires a newer macOS, so the
next runner upgrade cannot drop support silently.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
feliperodri requested review from a team as code owners November 13, 2026 02:12
@feliperodri feliperodri added the [I] CI / Infrastructure Work done to CI, tests and infrastructure. label Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[I] CI / Infrastructure Work done to CI, tests and infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants