Repository navigation
Fix invalid JSON in uf2families.json and add a JSON validation check - #111
Merged
Limor "Ladyada" Fried (ladyada) merged 2 commits intoNov 10, 2026
Merged
Limor "Ladyada" Fried (ladyada) merged 2 commits into
Limor "Ladyada" Fried (ladyada) merged 2 commits into
Conversation
The Adaboot entry added in microsoft#108 is missing a comma after its "id" field, which makes uf2families.json invalid JSON. uf2conv.py fails in load_families() with: json.decoder.JSONDecodeError: Expecting ',' delimiter: line 399 column 9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run jq over every tracked *.json file on push and pull_request so a syntax error in utils/uf2families.json (like the missing comma fixed in the previous commit) fails CI instead of breaking downstream users of uf2conv.py, many of which fetch the file straight from master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@microsoft-github-policy-service agree company="Adafruit" |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Scott Shawcroft (@tannewt) or Limor "Ladyada" Fried (@ladyada) please review and merge at your convenience. |
Limor "Ladyada" Fried (ladyada)
approved these changes
Nov 10, 2026
Limor "Ladyada" Fried (ladyada)
merged commit Nov 10, 2026
70fdee5
into
microsoft:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Adaboot entry added in #108 is missing a comma after its
"id"field, soutils/uf2families.jsononmasteris no longer valid JSON.uf2conv.pyfails as soon as it loads the families:Downstream CI that fetches
uf2conv.pyanduf2families.jsonstraight frommasterstarted failing after #108 was merged. That includes Adafruit's ci-arduino, which every ESP32-S2/S3 and SAMD UF2 build uses.Changes
Validate JSONworkflow. It runsjq emptyon every tracked*.jsonfile on push and pull_request (only when JSON files or the workflow change), plusworkflow_dispatch. The repo's only check today is CodeQL (javascript-typescript), which doesn't parse JSON, so it passed on Add Adaboot entry to uf2families.json #108.Testing
I ran the workflow step locally with jq 1.7.1:
OKmasterversion ofuf2families.json, the step exits 1 withjq: parse error: Expected separator between values at line 399, column 20json.loadalso parses the fixed file (80 families)🤖 Generated with Claude Code