Skip to content

Add Winui 2.2 framework package - #3622

Merged
3 commits merged into
microsoft:masterfrom
licanhua:winui
Nov 23, 2019
Merged

3 commits merged into
microsoft:masterfrom
licanhua:winui

Conversation

@licanhua

@licanhua Canhua Li (licanhua) commented Nov 7, 2019 •

Copy link
Copy Markdown
Contributor

Complete part of #3521. CLI templates change will be in another PR.

This is the integration with WinUI 2.2.190917002 framework package.
It’s a breaking change, and you may be impacted:
You are using an old version of WinUI like 2.1.
You are using WinUI prelease
Your product is not shipped from Store. You may have to install WinUI by yourself.

  1. _WinUIWorkaround is added to workaround problem WinUI issue 1512.
  2. All our name space is 'react.uwp', so I changed 'RootNamespace' to make mdmerge.exe happy. and CppWinRTNamespaceMergeDepth is added to avoid compilation error because of RootNamespace change.
Microsoft Reviewers: Open in CodeFlow

@licanhua
Canhua Li (licanhua) requested a review from a team as a code owner November 7, 2019 21:14
@ghost ghost added the vnext label Nov 7, 2019
@licanhua Canhua Li (licanhua) changed the title Add Winui prerelease nuget Add Winui 2.2 framework package Nov 8, 2019
Comment thread vnext/ReactUWP/ReactUWP.vcxproj Resolved
Comment thread vnext/ReactUWP/packages.config Resolved
@stecrain

Stephen Crain (stecrain) commented Nov 22, 2019 •

Copy link
Copy Markdown
Contributor

Are there any changes to the cli template needed as part of this?
Since you are advertising it as a breaking change I assume the cli template would need to be updated 🤔

@licanhua

Copy link
Copy Markdown
Contributor Author

Are there any changes to the cli template needed as part of this?
Since you are advertising it as a breaking change I assume the cli template would need to be updated 🤔

Good call. I reword the description. and it will be in the next PR

@licanhua Canhua Li (licanhua) added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Nov 23, 2019
@ghost

Copy link
Copy Markdown

Hello Canhua Li (@licanhua)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@kmelmon kmelmon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
ghost merged commit 160f555 into microsoft:master Nov 23, 2019
Canhua Li (licanhua) added a commit that referenced this pull request Nov 25, 2019
ghost pushed a commit that referenced this pull request Nov 25, 2019
* Revert "Add Winui 2.2 framework package (#3622)"

This reverts commit 160f555.

* Change files
@licanhua
Canhua Li (licanhua) restored the winui branch November 25, 2019 22:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants